From: Dan Malek <dan@embeddededge.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] 8xx: add cpm_get_cpmp()
Date: Sun, 7 Aug 2005 11:39:52 -0400 [thread overview]
Message-ID: <09b0792f426f1d5883cf5d437723f075@embeddededge.com> (raw)
In-Reply-To: <20050807043110.GA6316@dmt.cnet>
On Aug 7, 2005, at 12:31 AM, Marcelo Tosatti wrote:
> Aris, sounds like you should proceed with cpm_get_cpmp() and change all
> other drivers using it also.
It depends how you define the semantics of this function call.
Can you call it any (and all of the) time you need it, or does it
actually perform an ioremap() and you only want to call it
once?
I guess implemented properly it doesn't matter. On the first
call it should do the ioremap() and on subsequent calls it
just returns the mapping. This is one of those common
functions that should be in commproc.c.
Thanks.
-- Dan
next prev parent reply other threads:[~2005-08-07 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-06 18:03 [PATCH] 8xx: add cpm_get_cpmp() Aristeu Sergio Rozanski Filho
2005-08-06 23:27 ` Marcelo Tosatti
2005-08-06 23:42 ` Aristeu Sergio Rozanski Filho
2005-08-07 0:33 ` Marcelo Tosatti
2005-08-07 3:36 ` Dan Malek
2005-08-07 2:40 ` Dan Malek
2005-08-07 4:31 ` Marcelo Tosatti
2005-08-07 15:39 ` Dan Malek [this message]
2005-08-07 15:44 ` Aristeu Sergio Rozanski Filho
2005-08-07 15:57 ` Marcelo Tosatti
2005-08-07 19:18 ` Eugene Surovegin
2005-08-07 17:25 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09b0792f426f1d5883cf5d437723f075@embeddededge.com \
--to=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).