Re: [PATCH v7 7/7] [NOT TO BE MERGED] Export sysrq_mask

[Russell Currey <ruscur@russell.cc>]

On Tue, 2020-04-21 at 08:10 +0200, Christophe Leroy wrote:
> Le 20/04/2020 à 18:56, Christophe Leroy a écrit :
> > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > ---
> >   drivers/tty/sysrq.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> > index 5e0d0813da55..a0760bcd7a97 100644
> > --- a/drivers/tty/sysrq.c
> > +++ b/drivers/tty/sysrq.c
> > @@ -74,6 +74,7 @@ int sysrq_mask(void)
> >   		return 1;
> >   	return sysrq_enabled;
> >   }
> > +EXPORT_SYMBOL_GPL(sysrq_mask);
> 
> I don't understand, why does snowpatch still reports it can't test
> the 
> patch once whereas this patch fixes the upstream build ?

We don't bother building the patch if the base build fails.  The
majority of the time this is extra unnecessary work, and from what I've
seen most build upstream build breaks aren't fixed from within the
powerpc tree.

We might change this in future because you're right, it should show
that this patch fixes the build.

> 
> Christophe
> 
> 
> 
> >   
> >   /*
> >    * A value of 1 means 'all', other nonzero values are an op mask:
> >