From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <20070515222529.GA14881@lixom.net> References: <20070510200237.GA19756@mag.az.mvista.com> <20070510215730.GA25075@lixom.net> <17987.47155.935764.878634@cargo.ozlabs.ibm.com> <20070511170512.GH4452@austin.ibm.com> <20070515220616.GB2433@mag.az.mvista.com> <528646bc0705151519p5bcce91ctaaa4880cfc9e5902@mail.gmail.com> <20070515222529.GA14881@lixom.net> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <0A0574F0-C2DC-4C23-B006-76376FC9EAAD@kernel.crashing.org> From: Kumar Gala Subject: Re: arch/powerpc/sysdev: dumping ground or only for shared drivers? Date: Tue, 15 May 2007 17:30:58 -0500 To: olof@lixom.net (Olof Johansson) Cc: linuxppc-dev , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On May 15, 2007, at 5:25 PM, Olof Johansson wrote: > On Tue, May 15, 2007 at 04:19:05PM -0600, Grant Likely wrote: >> On 5/15/07, Mark A. Greer wrote: >>> On Tue, May 15, 2007 at 04:06:40PM -0500, Kumar Gala wrote: >>>> If this is how we are going we should move some code from arch/ >>>> powerpc/platforms into sysdev (for example the 5200 platform has >>>> its >>>> pic code and some other bits that would be candidate to move into >>>> sysdev). >>> >>> I like Paul's take as well and I don't like the idea of moving the >>> 5200 pci code, etc. to sysdev. I just can't explain why. >>> >>> But, I'll try anyway: >>> >>> The 5200 is an SoC so all the portions of that chip are tighly >>> coupled >>> with the 5200. It doesn't make sense to put half of the 5200 >>> code under >>> platforms and the other half under sysdev (unless the code is shared >>> with something that isn't a 5200). >> >> Actually, that's a good explaination >> >> I must agree. If there is little chance that the code will be >> used by >> any other platform, then don't split it up for the sake of (for >> example) putting all the pic code in the same place. I think there >> are fewer opportunities for confusion if only code that is actually >> shared goes in the shared directory. (ie. "how worried do I need to >> be about affecting other platforms when I modify this code?"). > > In other words, both of you agree with my original points, even though > Mark said first "I agree with Paul", and then gave the same reasons as > me for not putting non-shared stuff in sysdev. :-) > > Anyway, I don't care enough to try to persuade anyone to change stance > on the question, I mostly wanted it clarified before it gets out of > hand > in case it is NOT to be a dumping ground. I was just hoping for consistency but I guess that's too much to ask from all of us :) I just pondered moving the ipic code only used by 83xx into platforms/ 83xx, but decided I'm too lazy to issue to few git commands to actually do this. - k