[PATCH] powerpc: Transliterate author name and remove FIXME

[PATCH] powerpc: Transliterate author name and remove FIXME

[Thorsten Blum]

The name is Mimi Phuong-Thao Vo.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/powerpc/boot/rs6000.h | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/powerpc/boot/rs6000.h b/arch/powerpc/boot/rs6000.h
index a9d879155ef9..16df8f3c43f1 100644
--- a/arch/powerpc/boot/rs6000.h
+++ b/arch/powerpc/boot/rs6000.h
@@ -1,11 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /* IBM RS/6000 "XCOFF" file definitions for BFD.
    Copyright (C) 1990, 1991 Free Software Foundation, Inc.
-   FIXME: Can someone provide a transliteration of this name into ASCII?
-   Using the following chars caused a compiler warning on HIUX (so I replaced
-   them with octal escapes), and isn't useful without an understanding of what
-   character set it is.
-   Written by Mimi Ph\373\364ng-Th\345o V\365 of IBM
+   Written by Mimi Phuong-Thao Vo of IBM
    and John Gilmore of Cygnus Support.  */
 
 /********************** FILE HEADER **********************/
-- 
2.47.0

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Michael Ellerman]

Thorsten Blum <thorsten.blum@linux.dev> writes:
> The name is Mimi Phuong-Thao Vo.
 
Is that the correct spelling?

The github commit below suggests it's Mimi Phûông-Thåo Võ.

And presumably the author preferred that spelling, otherwise they would
have just written it in ASCII in the first place.

https://github.com/bminor/binutils-gdb/commit/6603bf38d74409906b3814f6a26c0483a5d32e41

cheers

> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  arch/powerpc/boot/rs6000.h | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/powerpc/boot/rs6000.h b/arch/powerpc/boot/rs6000.h
> index a9d879155ef9..16df8f3c43f1 100644
> --- a/arch/powerpc/boot/rs6000.h
> +++ b/arch/powerpc/boot/rs6000.h
> @@ -1,11 +1,7 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  /* IBM RS/6000 "XCOFF" file definitions for BFD.
>     Copyright (C) 1990, 1991 Free Software Foundation, Inc.
> -   FIXME: Can someone provide a transliteration of this name into ASCII?
> -   Using the following chars caused a compiler warning on HIUX (so I replaced
> -   them with octal escapes), and isn't useful without an understanding of what
> -   character set it is.
> -   Written by Mimi Ph\373\364ng-Th\345o V\365 of IBM
> +   Written by Mimi Phuong-Thao Vo of IBM
>     and John Gilmore of Cygnus Support.  */
>  
>  /********************** FILE HEADER **********************/
> -- 
> 2.47.0

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Thorsten Blum]

On 11. Nov 2024, at 02:11, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Thorsten Blum <thorsten.blum@linux.dev> writes:
>> The name is Mimi Phuong-Thao Vo.
> 
> Is that the correct spelling?

According to [1] it's correct.

Thanks,
Thorsten

[1] https://www.linkedin.com/in/mimi-phuong-thao-vo-5768033

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Thorsten Blum]

On 11. Nov 2024, at 02:11, Michael Ellerman wrote:
> Thorsten Blum <thorsten.blum@linux.dev> writes:
>> The name is Mimi Phuong-Thao Vo.
> 
> Is that the correct spelling?
> 
> The github commit below suggests it's Mimi Phûông-Thåo Võ.
> 
> And presumably the author preferred that spelling, otherwise they would
> have just written it in ASCII in the first place.
> 
> https://github.com/bminor/binutils-gdb/commit/6603bf38d74409906b3814f6a26c0483a5d32e41

Hi Michael,

Are you suggesting to keep "Mimi Ph\373\364ng-Th\345o V\365" and a FIXME
instead of changing it to "Mimi Phuong-Thao Vo" which is how she spells
her name on her LinkedIn profile and other websites?

I doubt anyone prefers their name to be spelled with octal escape
characters.

Thanks,
Thorsten

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Michael Ellerman]

Thorsten Blum <thorsten.blum@linux.dev> writes:
> On 11. Nov 2024, at 02:11, Michael Ellerman wrote:
>> Thorsten Blum <thorsten.blum@linux.dev> writes:
>>> The name is Mimi Phuong-Thao Vo.
>> 
>> Is that the correct spelling?
>> 
>> The github commit below suggests it's Mimi Phûông-Thåo Võ.
>> 
>> And presumably the author preferred that spelling, otherwise they would
>> have just written it in ASCII in the first place.
>> 
>> https://github.com/bminor/binutils-gdb/commit/6603bf38d74409906b3814f6a26c0483a5d32e41
>
> Hi Michael,
>
> Are you suggesting to keep "Mimi Ph\373\364ng-Th\345o V\365" and a FIXME
> instead of changing it to "Mimi Phuong-Thao Vo" which is how she spells
> her name on her LinkedIn profile and other websites?

No I'm not suggesting to leave it as-is.

But I also suspect they spell it that way on LinkedIn etc. because it's
the path of least resistance, not because it's the correct spelling.

I was hoping someone who's more familiar with Vietnamese (I believe)
spelling would chime in and tell us which is correct.

> I doubt anyone prefers their name to be spelled with octal escape
> characters.
 
Sure, but it wouldn't have been octal escapes in the original character
encoding, it would have appeared, I believe, as Mimi Phûông-Thåo Võ.

cheers

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Christophe Leroy]

Le 23/11/2024 à 04:01, Michael Ellerman a écrit :
> Thorsten Blum <thorsten.blum@linux.dev> writes:
>> On 11. Nov 2024, at 02:11, Michael Ellerman wrote:
>>> Thorsten Blum <thorsten.blum@linux.dev> writes:
>>>> The name is Mimi Phuong-Thao Vo.
>>>
>>> Is that the correct spelling?
>>>
>>> The github commit below suggests it's Mimi Phûông-Thåo Võ.
>>>
>>> And presumably the author preferred that spelling, otherwise they would
>>> have just written it in ASCII in the first place.
>>>
>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbminor%2Fbinutils-gdb%2Fcommit%2F6603bf38d74409906b3814f6a26c0483a5d32e41&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Ce09e131ad44342b0be9a08dd0b6b1c9b%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638679276875561424%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=5F8j2IkQc6sy8tnoBoNVlbxA2YyxptCfh92Gx9mi460%3D&reserved=0
>>
>> Hi Michael,
>>
>> Are you suggesting to keep "Mimi Ph\373\364ng-Th\345o V\365" and a FIXME
>> instead of changing it to "Mimi Phuong-Thao Vo" which is how she spells
>> her name on her LinkedIn profile and other websites?
> 
> No I'm not suggesting to leave it as-is.
> 
> But I also suspect they spell it that way on LinkedIn etc. because it's
> the path of least resistance, not because it's the correct spelling.
> 
> I was hoping someone who's more familiar with Vietnamese (I believe)
> spelling would chime in and tell us which is correct.
> 
>> I doubt anyone prefers their name to be spelled with octal escape
>> characters.
>   
> Sure, but it wouldn't have been octal escapes in the original character
> encoding, it would have appeared, I believe, as Mimi Phûông-Thåo Võ.
> 

Isn't our file just a copy of the one from binutils ? Shouldn't we 
adjust it based on commit 
https://github.com/bminor/binutils-gdb/commit/2ce18a16268a ?

Christophe

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Thorsten Blum]

On 23. Nov 2024, at 11:19, Christophe Leroy wrote:
> Isn't our file just a copy of the one from binutils ? Shouldn't we adjust it based on commit https://github.com/bminor/binutils-gdb/commit/2ce18a16268a ?

It looks like it's a copy and the name is spelled the same as in my patch:

  "Mimi Phuong-Thao Vo"

What's missing to get this merged?

Thanks,
Thorsten

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Thorsten Blum]

On 7. Jan 2025, at 13:16, Thorsten Blum wrote:
> On 23. Nov 2024, at 11:19, Christophe Leroy wrote:
>> Isn't our file just a copy of the one from binutils ? Shouldn't we adjust it based on commit https://github.com/bminor/binutils-gdb/commit/2ce18a16268a ?
> 
> It looks like it's a copy and the name is spelled the same as in my patch:
> 
>  "Mimi Phuong-Thao Vo"
> 
> What's missing to get this merged?

Anyone?

Thanks,
Thorsten

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Thorsten Blum]

On 7. Jan 2025, at 13:16, Thorsten Blum wrote:
> On 23. Nov 2024, at 11:19, Christophe Leroy wrote:
>> Isn't our file just a copy of the one from binutils ? Shouldn't we adjust it based on commit https://github.com/bminor/binutils-gdb/commit/2ce18a16268a ?
> 
> It looks like it's a copy and the name is spelled the same as in my patch:
> 
>  "Mimi Phuong-Thao Vo"
> 
> What's missing to get this merged?

Does it make sense to resubmit this or do we leave the name and the
FIXME as is?

Thanks,
Thorsten

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Christophe Leroy]

Le 13/05/2025 à 16:10, Thorsten Blum a écrit :
> On 7. Jan 2025, at 13:16, Thorsten Blum wrote:
>> On 23. Nov 2024, at 11:19, Christophe Leroy wrote:
>>> Isn't our file just a copy of the one from binutils ? Shouldn't we adjust it based on commit https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbminor%2Fbinutils-gdb%2Fcommit%2F2ce18a16268a&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cab93fab4ad1e43fbaaee08dd9227edf0%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638827422381661999%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=pYe0b3WZhhmX3IHNh58Ogf%2BFMLYsdA7zn93%2B74D%2F%2FsA%3D&reserved=0 ?
>>
>> It looks like it's a copy and the name is spelled the same as in my patch:
>>
>>   "Mimi Phuong-Thao Vo"
>>
>> What's missing to get this merged?
> 
> Does it make sense to resubmit this or do we leave the name and the
> FIXME as is?

Thanks for the ping, your patch is not lost, it is still here: 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20241110162139.5179-2-thorsten.blum@linux.dev/

Maddy, what do you think about the way forward ?

Thanks
Christophe

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Madhavan Srinivasan]

On 5/13/25 11:18 PM, Christophe Leroy wrote:
> 
> 
> Le 13/05/2025 à 16:10, Thorsten Blum a écrit :
>> On 7. Jan 2025, at 13:16, Thorsten Blum wrote:
>>> On 23. Nov 2024, at 11:19, Christophe Leroy wrote:
>>>> Isn't our file just a copy of the one from binutils ? Shouldn't we adjust it based on commit https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbminor%2Fbinutils-gdb%2Fcommit%2F2ce18a16268a&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cab93fab4ad1e43fbaaee08dd9227edf0%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638827422381661999%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=pYe0b3WZhhmX3IHNh58Ogf%2BFMLYsdA7zn93%2B74D%2F%2FsA%3D&reserved=0 ?
>>>
>>> It looks like it's a copy and the name is spelled the same as in my patch:
>>>
>>>   "Mimi Phuong-Thao Vo"
>>>
>>> What's missing to get this merged?
>>
>> Does it make sense to resubmit this or do we leave the name and the
>> FIXME as is?
> 
> Thanks for the ping, your patch is not lost, it is still here: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20241110162139.5179-2-thorsten.blum@linux.dev/
> 
> Maddy, what do you think about the way forward ?

Was waiting for someone to chime to confirm. But I guess will pull it in .

Thanks.


> 
> Thanks
> Christophe
> 

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

[Madhavan Srinivasan]

On Sun, 10 Nov 2024 17:21:37 +0100, Thorsten Blum wrote:
> The name is Mimi Phuong-Thao Vo.
> 
> 

Applied to powerpc/next.

[1/1] powerpc: Transliterate author name and remove FIXME
      https://git.kernel.org/powerpc/c/8bc3252436d371e7ac505f9f2685611090680a48

Thanks