From: Kumar Gala <galak@kernel.crashing.org>
To: Bradley Hughes <bhughes@silicontkx.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] DTS: Adding device tree source for the STx GP3 SSA MPC8555-based board.
Date: Wed, 21 Jul 2010 15:17:37 -0500 [thread overview]
Message-ID: <0DF9688A-14A9-46F6-84E4-798839A95CDC@kernel.crashing.org> (raw)
In-Reply-To: <AANLkTinoCJrYTdc56uK0ELQGMfG-em_5iiTtGGGWCgPT@mail.gmail.com>
On Jul 21, 2010, at 11:52 AM, Bradley Hughes wrote:
> On Wed, Jul 21, 2010 at 10:24 AM, Kumar Gala =
<galak@kernel.crashing.org> wrote:
>>>=20
>>> + soc8555@e0000000 {
>>> + #address-cells =3D <1>;
>>> + #size-cells =3D <1>;
>>> + device_type =3D "soc";
>>> + compatible =3D "simple-bus";
>>> + ranges =3D <0x0 0xe0000000 0x100000>;
>>> + bus-frequency =3D <0>;
>>> +
>>> + ecm-law@0 {
>>> + compatible =3D "fsl,ecm-law";
>>> + reg =3D <0x0 0x1000>;
>>> + fsl,num-laws =3D <8>;
>>> + };
>>> +
>>> + ecm@1000 {
>>> + compatible =3D "fsl,mpc8555-ecm", "fsl,ecm";
>>> + reg =3D <0x1000 0x1000>;
>>> + interrupts =3D <17 2>;
>>> + interrupt-parent =3D <&mpic>;
>>> + };
>>> +
>>> + memory-controller@2000 {
>>> + compatible =3D "fsl,8555-memory-controller";
>>=20
>> fsl,mpc8555?
>=20
> Ah, yes -- it seems the dts I used for an example also has this
> problem. In drivers/edac/mpc85xx_edac.c, bindings still work for
> fsl,85.. style notation, but a comment claims that this notation would
> be deprecated at some point (2.6.29 or 2.6.30). I have updated my
> local copy and it works fine, should I send a new patch? I could also
> extend this change to the other DTS files affected (A quick search
> found 14 instances of fsl,85.. style notation.) Please let me know
> what I should do.
Send two patches. One to update your patch and another to fix the in =
tree dts that have the old name.
- k=
prev parent reply other threads:[~2010-07-21 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 22:39 [PATCH] DTS: Adding device tree source for the STx GP3 SSA MPC8555-based board Bradley Hughes
2010-07-21 14:24 ` Kumar Gala
2010-07-21 16:52 ` Bradley Hughes
2010-07-21 20:17 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DF9688A-14A9-46F6-84E4-798839A95CDC@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=bhughes@silicontkx.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox