Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

Olof Johansson
2007-09-11T17:14:27Z

On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote:
>
> On Sep 11, 2007, at 10:55 AM, Olof Johansson wrote:
>
> > On Tue, Sep 11, 2007 at 10:50:18AM -0500, Kumar Gala wrote:

> >>> How different are these boards really? Could you just detect
> >>> MPC85xxDS
> >>> and have a generic platform for them, or are they different
> >>> enough that
> >>> you need individual ones for it?
> >>
> >> I wanted a different probe. I figured having a different struct
> >> was a
> >> simple solution.
> >
> > Seems like the only reason to need that is the setting of
> > primary_phb_addr. Can't that information be derived out of the device
> > tree instead? That'd avoid alot of code duplication (code that
> > includes
> > ifdefs, FWIW :-)
>
> well the ifdefs are orthogonal. We don't have a way of knowing
> primary from the device tree today.

How about something like "fsl,primary-phb" in the bus device node? I don't
know, maybe it's already been discussed and turned down for some reason.

Or would it be sufficient to check children of that device node to see
if the ULi is on that bus?

> > It just seems like a slippery slope. I'm not objecting directly to
> > this
> > patch, but I think it should be fixed for the longer term.
>
> Once we have a clean way of knowing primary PHB than I'm happy to fixup.

-Olof