From: Geoff Levand <geoff@infradead.org>
To: Li Zetao <lizetao1@huawei.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH -next] net/ps3_gelic_net: Use ether_addr_to_u64() to convert ethernet address
Date: Tue, 8 Aug 2023 10:32:09 -0700 [thread overview]
Message-ID: <0a0249e9-c408-696c-1ee1-c74b053c488b@infradead.org> (raw)
In-Reply-To: <20230808114050.4034547-1-lizetao1@huawei.com>
Hi,
On 8/8/23 04:40, Li Zetao wrote:
> Use ether_addr_to_u64() to convert an Ethernet address into a u64 value,
> instead of directly calculating, as this is exactly what
> this function does.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
I tested this on PS3 and it seems to be working OK.
Thanks for your contribution.
Tested-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2023-08-08 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 11:40 [PATCH -next] net/ps3_gelic_net: Use ether_addr_to_u64() to convert ethernet address Li Zetao
2023-08-08 17:32 ` Geoff Levand [this message]
2023-08-09 14:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a0249e9-c408-696c-1ee1-c74b053c488b@infradead.org \
--to=geoff@infradead.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lizetao1@huawei.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).