From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Abhishek Goel <huntbag@linux.vnet.ibm.com>,
rjw@rjwysocki.net, daniel.lezcano@linaro.org, paulus@samba.org,
mpe@ellerman.id.au, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: stewart@linux.vnet.ibm.com
Subject: Re: [PATCH v2] cpuidle/powernv : Add Description for cpuidle state
Date: Mon, 04 Jun 2018 19:04:14 +1000 [thread overview]
Message-ID: <0a28154deb468669a59c120a90d4aedc1e1e705b.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180604081758.104201-1-huntbag@linux.vnet.ibm.com>
On Mon, 2018-06-04 at 13:47 +0530, Abhishek Goel wrote:
> + if (of_property_read_string_array(power_mgt,
> + "ibm,cpu-idle-state-descs", descs, dt_idle_states) < 0) {
> + of_property_read_string_array(power_mgt,
> + "ibm,cpu-idle-state-names", descs, dt_idle_states);
> + pr_warn("cpuidle-powernv: missing ibm,cpu-idle-state-descs in DT\n"
> + "Name will be used for description\n");
> + }
>
> /*
Is this a new property ? I'm not fan of adding yet another of those
silly arrays.
I would say this is the right time now to switch over to a node per
state instead, as we discussed with Vaidy.
Additionally, while doing that, we can provide the versioning mechanism
I proposed so we can deal with state specific issues and erratas.
Cheers,
Ben.
next prev parent reply other threads:[~2018-06-04 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 8:17 [PATCH v2] cpuidle/powernv : Add Description for cpuidle state Abhishek Goel
2018-06-04 9:04 ` Benjamin Herrenschmidt [this message]
2018-06-04 11:45 ` Akshay Adiga
2018-06-05 8:54 ` Abhishek
2018-06-05 9:08 ` Akshay Adiga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a28154deb468669a59c120a90d4aedc1e1e705b.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=daniel.lezcano@linaro.org \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rjw@rjwysocki.net \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).