From: Segher Boessenkool <segher@kernel.crashing.org>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb
Date: Thu, 9 Aug 2007 22:21:02 +0200 [thread overview]
Message-ID: <0aede121098dd1b4ed6cdf9ca43b20fe@kernel.crashing.org> (raw)
In-Reply-To: <20070808170728.GA21118@localhost.localdomain>
> - cosmetic cleanups (@01 -> @1);
That's a correctness fix, not just cosmetics.
> - other non-mandatory (device-id, device_type, compatible, ...)
> properties removed from mmc node, today board file is using
> of_find_node_by_name(), instead of of_find_compatible_node();
That's the wrong way around -- a driver (or platform code, same
thing) isn't using "compatible", while it should, so you remove
"compatible"?
Segher
prev parent reply other threads:[~2007-08-09 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 17:07 [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb Anton Vorontsov
2007-08-08 17:09 ` [PATCH v3 1/2] [POWERPC] MPC832x_RDB: update dts to use spi, register mmc_spi stub Anton Vorontsov
2007-08-09 3:07 ` David Gibson
2007-08-09 20:15 ` Segher Boessenkool
2007-08-10 1:02 ` David Gibson
2007-08-10 20:42 ` Segher Boessenkool
2007-08-12 8:16 ` David Gibson
2007-08-12 11:36 ` Segher Boessenkool
2007-08-08 17:09 ` [PATCH v3 2/2] [POWERPC] fsl_soc: add support for fsl_spi Anton Vorontsov
2007-08-09 5:33 ` Kumar Gala
2007-08-09 5:34 ` [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb Kumar Gala
2007-08-09 20:21 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aede121098dd1b4ed6cdf9ca43b20fe@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).