linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Joel Savitz <jsavitz@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: Gonzalo Siero <gsierohu@redhat.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Benjamin Gray <bgray@linux.ibm.com>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: align memory_limit to 16MB in early_parse_mem
Date: Mon, 4 Mar 2024 12:28:23 +0530	[thread overview]
Message-ID: <0b1ebda7-cf70-47bc-9d31-129eb895ae9f@kernel.org> (raw)
In-Reply-To: <87cysdfsef.fsf@mail.lhotse>

On 3/2/24 4:53 AM, Michael Ellerman wrote:
> Hi Joel,
> 
> Joel Savitz <jsavitz@redhat.com> writes:
>> On 64-bit powerpc, usage of a non-16MB-aligned value for the mem= kernel
>> cmdline parameter results in a system hang at boot.
> 
> Can you give us any more details on that? It might be a bug we can fix.
> 
>> For example, using 'mem=4198400K' will always reproduce this issue.
>>
>> This patch fixes the problem by aligning any argument to mem= to 16MB
>> corresponding with the large page size on powerpc.
> 
> The large page size depends on the MMU, with Radix it's 2MB or 1GB. So
> depending on what's happening 16MB may not be enough.
> 
> What system are you testing on?
> 

htab_bolt_mapping should have aligned things to a lower value that is 16MB aligned.

	/* Carefully map only the possible range */
	vaddr = ALIGN(vstart, step);
	paddr = ALIGN(pstart, step);
	vend  = ALIGN_DOWN(vend, step);



-aneesh


  parent reply	other threads:[~2024-03-04  6:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 20:30 [PATCH] powerpc: align memory_limit to 16MB in early_parse_mem Joel Savitz
2024-03-01 23:23 ` Michael Ellerman
2024-03-02 23:59   ` Joel Savitz
2024-03-08  9:30     ` Michael Ellerman
2024-03-04  6:58   ` Aneesh Kumar K.V [this message]
2024-03-08 10:18 ` Aneesh Kumar K.V
2024-03-26  4:45   ` Joel Savitz
2024-04-01 14:17     ` Joel Savitz
2024-04-10 15:22       ` Joel Savitz
2024-04-10 15:31         ` Christophe Leroy
2024-04-10 16:52           ` Joel Savitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b1ebda7-cf70-47bc-9d31-129eb895ae9f@kernel.org \
    --to=aneesh.kumar@kernel.org \
    --cc=bgray@linux.ibm.com \
    --cc=gsierohu@redhat.com \
    --cc=jsavitz@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).