From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3B8AC54ED1 for ; Thu, 22 May 2025 22:26:13 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b3NDN2GmTz2yVP; Fri, 23 May 2025 08:26:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::f30" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747952772; cv=none; b=avqy9szY6VKBk39X6yYe4ojvhDx7/Gmqs4jaqid0CTELdzJDta31oS2WwTh0kG/ehb4T9JnNntSeizSlIIZlimD47HuRFT5ImWEoTx31gNJasiIN8gZnvOxmjatm0vsCe7Cjsv4gyUqrXqhavpcQtMg4SJD3za4BRkASk+3HqrAQWetahZIFJbw5p0HfH3XOSZbuu8q71FxCdNxdEw/J7C4zY9mWiPC5BgBSNyYJNkLE6e1yzn0v1TbQ9uHBIDEBa2k62t7R5j1J2qmyudclUaohYhWs06fDcZXthBJU3nMlYV7MHX4/NEkk98UyParQ059sIfWmsZq4oeNdeAeDMg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747952772; c=relaxed/relaxed; bh=Jmptf5RMBQqSn8lkxlWoyMCjmS+Mv7H8iKTTl/Kwouo=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=iowns7qRSPIaYyFTRJxSci1sp/NpsTf11F+1ShqDhwRPbEiCM0ntWIpA8XBQBw86Pe+5P39SWBaZnW1J0kh4MPHE6phOBQsVJcUuFU1/Sp6+EJLHGMDAsPbT2zHaLRxiXKLYSwjGjcYq8GpQoTPGWaNA31gYM9MvxC980weGog/Pgw3blcbGso7HtD4awy4rMf9ssaVylc2i+3AWLf5Szw2nu9VxgfkDxGywDNFNw3dVI2NJy2r9RvkQsnAlZ3yXSDj4WthDGJ5YTNsENk49Yy+AWQjisyLbcftzV9gxm/vr01qMx1gf9Q7W3BsUoaay2DNa2wm2bgvo9aKIIBN6Qw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; dkim=pass (2048-bit key; unprotected) header.d=paul-moore.com header.i=@paul-moore.com header.a=rsa-sha256 header.s=google header.b=TKOkWmZo; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::f30; helo=mail-qv1-xf30.google.com; envelope-from=paul@paul-moore.com; receiver=lists.ozlabs.org) smtp.mailfrom=paul-moore.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=paul-moore.com header.i=@paul-moore.com header.a=rsa-sha256 header.s=google header.b=TKOkWmZo; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=paul-moore.com (client-ip=2607:f8b0:4864:20::f30; helo=mail-qv1-xf30.google.com; envelope-from=paul@paul-moore.com; receiver=lists.ozlabs.org) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b3NDM13q2z2yNG for ; Fri, 23 May 2025 08:26:10 +1000 (AEST) Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-6fa8eca392dso9928726d6.0 for ; Thu, 22 May 2025 15:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1747952767; x=1748557567; darn=lists.ozlabs.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=Jmptf5RMBQqSn8lkxlWoyMCjmS+Mv7H8iKTTl/Kwouo=; b=TKOkWmZo25Cfp+K4ovfZzCpdGYLBRQyg+zEAa4fmaMl8Oc6KPWP+NVY+0lLAYrKSyj LeHkB9YokTaCjPc0tMQJ6gBGQe0TEQa+t01v8SRgkjFQAfv75fRalT+jvgCvPfympy82 pUXt7qAhPRRRBlZcKrnrIlr78rK+MueMtxL+QZEriL5PqAHEgjK1oV+ySntk/PS+rrFU BAlhTn0T+PntIMZcj+w8WujYD0IFFxkb49EFhg6ame78C+b8YdKopyyTH9D4jcLlZR6J UOReac7s6EoV0DGUG7lilGwKz6BsvbbsRAdAmhfHhs4gQIOAmzg0v5t5LVV/5o4RRHC7 bfhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747952767; x=1748557567; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Jmptf5RMBQqSn8lkxlWoyMCjmS+Mv7H8iKTTl/Kwouo=; b=PhpEWsPe0iOBrvYl1gBsAu1wT0wDtt4k+NHWeYCvs6f/23CXufWs1YtGctNaoxfzSl QauyI2YP51N5msrt+Bsw/rP2vFoLuu07XPhj2i0qMy704YElJszmZFwhmEVUMSEhQxxS RFi6xCccdyEXfrWlwtY+iZBhi3hnJWZAUks9d1B5Elf2rQZqnFN73UHqzfdcaQPnwj9Z xFYya1cOzwv/Uo9xr9Qea+LKXbjGrpLsCv9epxscKsTE7IDODloEyZxGKyoUoZLBphjz /Kgaa5DpQVLHop9dvd7WczMrufx/rlLqacoxLDn2CIvcVlQ9j4LRgVqc4kfFk4OmyWqt /CHw== X-Forwarded-Encrypted: i=1; AJvYcCWniJY2n9t7O/DRaAyTGVXkVx8OH3+Ur57EcxEC/0EXFYQqGJoLlLpcm5DUbYD4HLhep3C/x8GA3CfUA2E=@lists.ozlabs.org X-Gm-Message-State: AOJu0YwiMzJrxfElOIMrO8XwV5q5smPHYxuSxZHd3924lZJT5K3EUgJI +vUZjGU0KNDv/28tDDaqC+1wRAS8n9sSBcFFoBTMkoYlhcQAGMLwXoKsAhE+BlvMlQ== X-Gm-Gg: ASbGncv5rJhAPShamEoIbo7b3u5wuwjuSBJhNozmDJtof1HswIYnHTUOH7FvWKkIo9S du9adlfeO9gEnsqRR6Ne9yk580XXJiUoe64dgGEmhXjYz/j5OrqX1elfAXC0N+zD500D2nsoRCq tbPpjDgwaAOKDw+zqEVWXL3l9CeJqVTsG7ZYkfJeJXy7JpzuiWywjp7NeuvIzoZP7DAcvyJiIye SlisV2egO3UoxXgP7KbwD00XXH6Vm0DCUuAW8jGS3mjgIdRS4geh2T8lGyKqqb/onsTVO3vC1ls m4lBF6Vpqj74oKh+yzKtDU+yTgGAtlkGg8N73Uy5aU+/q3fCDhHwSBu5iJUJbCPZ+ri1uKHfAL7 jl6oynL9vf/8/PUzIarCz X-Google-Smtp-Source: AGHT+IE2zN7SH+0SaGrs2tzepSFkLMKNXBgIbbn8M9DQcRbDJBs1dDzlx85ZuSxbIPErdUE31K4qXg== X-Received: by 2002:a05:6214:1947:b0:6f2:b094:430e with SMTP id 6a1803df08f44-6f8b0829131mr503375636d6.25.1747952766984; Thu, 22 May 2025 15:26:06 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6f8b0987259sm105076766d6.120.2025.05.22.15.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 15:26:06 -0700 (PDT) Date: Thu, 22 May 2025 18:26:05 -0400 Message-ID: <0bb73a49ccbc93e90ea87c0dbb4097ae@paul-moore.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20250522_1740/pstg-lib:20250522_1730/pstg-pwork:20250522_1740 From: Paul Moore To: Andrey Albershteyn , Richard Henderson , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Alexander Viro , Christian Brauner , Jan Kara , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Arnd Bergmann , =?UTF-8?Q?Pali_Roh=C3=A1r?= , James Morris , "Serge E. Hallyn" , Stephen Smalley , Ondrej Mosnacek , Tyler Hicks , Miklos Szeredi , Amir Goldstein Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, selinux@vger.kernel.org, ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, Andrey Albershteyn Subject: Re: [PATCH v5 2/7] lsm: introduce new hooks for setting/getting inode fsxattr References: <20250513-xattrat-syscall-v5-2-22bb9c6c767f@kernel.org> In-Reply-To: <20250513-xattrat-syscall-v5-2-22bb9c6c767f@kernel.org> On May 13, 2025 Andrey Albershteyn wrote: > > Introduce new hooks for setting and getting filesystem extended > attributes on inode (FS_IOC_FSGETXATTR). > > Cc: selinux@vger.kernel.org > Cc: Paul Moore > > Signed-off-by: Andrey Albershteyn > --- > fs/file_attr.c | 19 ++++++++++++++++--- > include/linux/lsm_hook_defs.h | 2 ++ > include/linux/security.h | 16 ++++++++++++++++ > security/security.c | 30 ++++++++++++++++++++++++++++++ > 4 files changed, 64 insertions(+), 3 deletions(-) The only thing that gives me a slight pause is that on a set operation we are going to hit both the get and set LSM hooks, but since the code does call into the getter on a set operation this is arguably the right thing. Acked-by: Paul Moore -- paul-moore.com