* [PATCH -next] ocxl: simplify the return expression of free_function_dev()
@ 2020-09-21 13:10 Qinglang Miao
2020-09-21 15:34 ` Frederic Barrat
2020-09-28 1:24 ` Andrew Donnellan
0 siblings, 2 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-09-21 13:10 UTC (permalink / raw)
To: Frederic Barrat, Andrew Donnellan, Arnd Bergmann,
Greg Kroah-Hartman
Cc: linuxppc-dev, linux-kernel, Qinglang Miao
Simplify the return expression.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/misc/ocxl/core.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/misc/ocxl/core.c b/drivers/misc/ocxl/core.c
index b7a09b21a..aebfc53a2 100644
--- a/drivers/misc/ocxl/core.c
+++ b/drivers/misc/ocxl/core.c
@@ -327,14 +327,9 @@ static void free_function_dev(struct device *dev)
static int set_function_device(struct ocxl_fn *fn, struct pci_dev *dev)
{
- int rc;
-
fn->dev.parent = &dev->dev;
fn->dev.release = free_function_dev;
- rc = dev_set_name(&fn->dev, "ocxlfn.%s", dev_name(&dev->dev));
- if (rc)
- return rc;
- return 0;
+ return dev_set_name(&fn->dev, "ocxlfn.%s", dev_name(&dev->dev));
}
static int assign_function_actag(struct ocxl_fn *fn)
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] ocxl: simplify the return expression of free_function_dev()
2020-09-21 13:10 [PATCH -next] ocxl: simplify the return expression of free_function_dev() Qinglang Miao
@ 2020-09-21 15:34 ` Frederic Barrat
2020-09-28 1:24 ` Andrew Donnellan
1 sibling, 0 replies; 3+ messages in thread
From: Frederic Barrat @ 2020-09-21 15:34 UTC (permalink / raw)
To: Qinglang Miao, Andrew Donnellan, Arnd Bergmann,
Greg Kroah-Hartman
Cc: linuxppc-dev, linux-kernel
Le 21/09/2020 à 15:10, Qinglang Miao a écrit :
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
Thanks!
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/ocxl/core.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/misc/ocxl/core.c b/drivers/misc/ocxl/core.c
> index b7a09b21a..aebfc53a2 100644
> --- a/drivers/misc/ocxl/core.c
> +++ b/drivers/misc/ocxl/core.c
> @@ -327,14 +327,9 @@ static void free_function_dev(struct device *dev)
>
> static int set_function_device(struct ocxl_fn *fn, struct pci_dev *dev)
> {
> - int rc;
> -
> fn->dev.parent = &dev->dev;
> fn->dev.release = free_function_dev;
> - rc = dev_set_name(&fn->dev, "ocxlfn.%s", dev_name(&dev->dev));
> - if (rc)
> - return rc;
> - return 0;
> + return dev_set_name(&fn->dev, "ocxlfn.%s", dev_name(&dev->dev));
> }
>
> static int assign_function_actag(struct ocxl_fn *fn)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] ocxl: simplify the return expression of free_function_dev()
2020-09-21 13:10 [PATCH -next] ocxl: simplify the return expression of free_function_dev() Qinglang Miao
2020-09-21 15:34 ` Frederic Barrat
@ 2020-09-28 1:24 ` Andrew Donnellan
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2020-09-28 1:24 UTC (permalink / raw)
To: Qinglang Miao, Frederic Barrat, Arnd Bergmann, Greg Kroah-Hartman
Cc: linuxppc-dev, linux-kernel
On 21/9/20 11:10 pm, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Looks good
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-28 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-21 13:10 [PATCH -next] ocxl: simplify the return expression of free_function_dev() Qinglang Miao
2020-09-21 15:34 ` Frederic Barrat
2020-09-28 1:24 ` Andrew Donnellan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).