From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F93C43466 for ; Mon, 21 Sep 2020 16:29:53 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E4572396D for ; Mon, 21 Sep 2020 16:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="WdGI3zK/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E4572396D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Bw8zc73HWzDqWm for ; Tue, 22 Sep 2020 02:29:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=fbarrat@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=WdGI3zK/; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Bw7mN0LnfzDqWj for ; Tue, 22 Sep 2020 01:34:58 +1000 (AEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08LFW5AR065829; Mon, 21 Sep 2020 11:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=eOuvleoisJLOkfYrr6Wvhr73JMHk+mzZFLo3r3/rWr4=; b=WdGI3zK/c0E1ppXDH4DtIKE2zjXpjdGbWjCU59mI8AYUqlWJmMLs59GJfMs1ceH19J76 TbGZfJY3Rsw8mRMnVqmzXnzbNfYjkVnuS2vsz62OomaBzyuSmqcWTTe9N5LmsDbhorfI v+8AfSVoMJ3J5zl+1Y5m1eijZZl/Em86wCylQdcjqxlxprth9xsExitCP29lwYIHeMCg BtEkLuxPG2Rr6BCz8+eKECd2oveK/dq2H+5NVvCHMTupp84wCEWGxC4Xf1lDwRBBoN// wIaZA1l+0VOOIATsDpN9XI9yvkpjoy3bdyy0iAQkfOZltfw7tXH9V8HTx5jNIOr7CFIN xg== Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 33pxw902ss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Sep 2020 11:34:39 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 08LFUJqZ002660; Mon, 21 Sep 2020 15:34:37 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma01fra.de.ibm.com with ESMTP id 33n9m7s4dm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Sep 2020 15:34:37 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 08LFYZlS32113026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Sep 2020 15:34:35 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1AF094C046; Mon, 21 Sep 2020 15:34:35 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D85F54C04A; Mon, 21 Sep 2020 15:34:34 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.187.68]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 21 Sep 2020 15:34:34 +0000 (GMT) Subject: Re: [PATCH -next] ocxl: simplify the return expression of free_function_dev() To: Qinglang Miao , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman References: <20200921131047.92526-1-miaoqinglang@huawei.com> From: Frederic Barrat Message-ID: <0dbda6be-6b5f-aeb7-76fa-39c5637fd758@linux.ibm.com> Date: Mon, 21 Sep 2020 17:34:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200921131047.92526-1-miaoqinglang@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-21_05:2020-09-21, 2020-09-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1011 lowpriorityscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 suspectscore=2 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210110 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 21/09/2020 à 15:10, Qinglang Miao a écrit : > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- Thanks! Acked-by: Frederic Barrat > drivers/misc/ocxl/core.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/misc/ocxl/core.c b/drivers/misc/ocxl/core.c > index b7a09b21a..aebfc53a2 100644 > --- a/drivers/misc/ocxl/core.c > +++ b/drivers/misc/ocxl/core.c > @@ -327,14 +327,9 @@ static void free_function_dev(struct device *dev) > > static int set_function_device(struct ocxl_fn *fn, struct pci_dev *dev) > { > - int rc; > - > fn->dev.parent = &dev->dev; > fn->dev.release = free_function_dev; > - rc = dev_set_name(&fn->dev, "ocxlfn.%s", dev_name(&dev->dev)); > - if (rc) > - return rc; > - return 0; > + return dev_set_name(&fn->dev, "ocxlfn.%s", dev_name(&dev->dev)); > } > > static int assign_function_actag(struct ocxl_fn *fn) >