From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: YueHaibing <yuehaibing@huawei.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"paulus@samba.org" <paulus@samba.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] powerpc/book3e: Fix build error
Date: Tue, 17 May 2022 10:45:01 +0000 [thread overview]
Message-ID: <0e8b7931-9bfb-1948-c141-c4e612ba0fe6@csgroup.eu> (raw)
In-Reply-To: <20220517094830.27560-1-yuehaibing@huawei.com>
Le 17/05/2022 à 11:48, YueHaibing a écrit :
> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
> early_get_first_memblock_info(__va(dt_ptr), &size);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add missing include file linux/of_fdt.h to fix this.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thats for fixing that.
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
It means we don't have any defconfig for 32 bits booke with
CONFIG_RELOCATABLE ?
> ---
> arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
> index 08a984e29433..093da4dbdee1 100644
> --- a/arch/powerpc/mm/nohash/fsl_book3e.c
> +++ b/arch/powerpc/mm/nohash/fsl_book3e.c
> @@ -36,6 +36,7 @@
> #include <linux/delay.h>
> #include <linux/highmem.h>
> #include <linux/memblock.h>
> +#include <linux/of_fdt.h>
>
> #include <asm/io.h>
> #include <asm/mmu_context.h>
next prev parent reply other threads:[~2022-05-17 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 9:48 [PATCH -next] powerpc/book3e: Fix build error YueHaibing
2022-05-17 10:45 ` Christophe Leroy [this message]
2022-05-17 11:31 ` YueHaibing
2022-05-18 4:50 ` Michael Ellerman
2022-05-24 11:09 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8b7931-9bfb-1948-c141-c4e612ba0fe6@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox