From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <17238.52279.428407.411558@cargo.ozlabs.ibm.com> References: <17238.52279.428407.411558@cargo.ozlabs.ibm.com> Mime-Version: 1.0 (Apple Message framework v622) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <0f2d7ce137c9ab4123647a0c9fedcffe@freescale.com> From: Becky Bruce Date: Wed, 19 Oct 2005 18:41:21 -0500 To: Paul Mackerras Cc: linuxppc64-dev@ozlabs.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH] powerpc: merge types.h List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Gack! While I doubt that should break anything, I can't promise 100% that it won't. I'll resubmit with that wrapped up in a nice shiny ifdef. Thanks for the catch - I wouldn't want irate users picketing my house :) Cheers, B On Oct 19, 2005, at 5:44 PM, Paul Mackerras wrote: > Becky Bruce writes: > >> This patch merges types.h into include/asm-powerpc. The only real >> changes >> here are that umode_t has become short instead of int in the 64-bit >> case, >> which appears to match what most other platforms have done. > > Ummm, isn't that an ABI change? We don't want to do that unless > you're completely absolutely positively sure it couldn't possibly > cause any userspace breakage. > > Regards, > Paul.