* [PATCH] powerpc/64s: Fix early_init_mmu section mismatch
@ 2020-04-29 7:02 Nicholas Piggin
2020-05-17 10:12 ` Christian Zigotzky
2020-06-09 5:29 ` Michael Ellerman
0 siblings, 2 replies; 5+ messages in thread
From: Nicholas Piggin @ 2020-04-29 7:02 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin, Christian Zigotzky
Christian reports:
MODPOST vmlinux.o
WARNING: modpost: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in
reference from the function .early_init_mmu() to the function
.init.text:.radix__early_init_mmu()
The function .early_init_mmu() references
the function __init .radix__early_init_mmu().
This is often because .early_init_mmu lacks a __init
annotation or the annotation of .radix__early_init_mmu is wrong.
WARNING: modpost: vmlinux.o(.text.unlikely+0x1ac): Section mismatch in
reference from the function .early_init_mmu() to the function
.init.text:.hash__early_init_mmu()
The function .early_init_mmu() references
the function __init .hash__early_init_mmu().
This is often because .early_init_mmu lacks a __init
annotation or the annotation of .hash__early_init_mmu is wrong.
The compiler is uninlining early_init_mmu and not putting it in an init
section because there is no annotation. Add it.
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/include/asm/book3s/64/mmu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/book3s/64/mmu.h b/arch/powerpc/include/asm/book3s/64/mmu.h
index bb3deb76c951..3ffe5f967483 100644
--- a/arch/powerpc/include/asm/book3s/64/mmu.h
+++ b/arch/powerpc/include/asm/book3s/64/mmu.h
@@ -208,7 +208,7 @@ void hash__early_init_devtree(void);
void radix__early_init_devtree(void);
extern void hash__early_init_mmu(void);
extern void radix__early_init_mmu(void);
-static inline void early_init_mmu(void)
+static inline void __init early_init_mmu(void)
{
if (radix_enabled())
return radix__early_init_mmu();
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/64s: Fix early_init_mmu section mismatch
2020-04-29 7:02 [PATCH] powerpc/64s: Fix early_init_mmu section mismatch Nicholas Piggin
@ 2020-05-17 10:12 ` Christian Zigotzky
2020-05-18 2:40 ` Michael Ellerman
2020-06-09 5:29 ` Michael Ellerman
1 sibling, 1 reply; 5+ messages in thread
From: Christian Zigotzky @ 2020-05-17 10:12 UTC (permalink / raw)
To: Nicholas Piggin, linuxppc-dev
Hi All,
This patch wasn't included in the PowerPC fixes 5.7-4. Please add it.
Thanks,
Christian
On 29 April 2020 at 09:02 am, Nicholas Piggin wrote:
> Christian reports:
>
> MODPOST vmlinux.o
> WARNING: modpost: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in
> reference from the function .early_init_mmu() to the function
> .init.text:.radix__early_init_mmu()
> The function .early_init_mmu() references
> the function __init .radix__early_init_mmu().
> This is often because .early_init_mmu lacks a __init
> annotation or the annotation of .radix__early_init_mmu is wrong.
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x1ac): Section mismatch in
> reference from the function .early_init_mmu() to the function
> .init.text:.hash__early_init_mmu()
> The function .early_init_mmu() references
> the function __init .hash__early_init_mmu().
> This is often because .early_init_mmu lacks a __init
> annotation or the annotation of .hash__early_init_mmu is wrong.
>
> The compiler is uninlining early_init_mmu and not putting it in an init
> section because there is no annotation. Add it.
>
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/powerpc/include/asm/book3s/64/mmu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/book3s/64/mmu.h b/arch/powerpc/include/asm/book3s/64/mmu.h
> index bb3deb76c951..3ffe5f967483 100644
> --- a/arch/powerpc/include/asm/book3s/64/mmu.h
> +++ b/arch/powerpc/include/asm/book3s/64/mmu.h
> @@ -208,7 +208,7 @@ void hash__early_init_devtree(void);
> void radix__early_init_devtree(void);
> extern void hash__early_init_mmu(void);
> extern void radix__early_init_mmu(void);
> -static inline void early_init_mmu(void)
> +static inline void __init early_init_mmu(void)
> {
> if (radix_enabled())
> return radix__early_init_mmu();
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/64s: Fix early_init_mmu section mismatch
2020-05-17 10:12 ` Christian Zigotzky
@ 2020-05-18 2:40 ` Michael Ellerman
2020-05-18 7:05 ` Christian Zigotzky
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2020-05-18 2:40 UTC (permalink / raw)
To: Christian Zigotzky, Nicholas Piggin, linuxppc-dev
Christian Zigotzky <chzigotzky@xenosoft.de> writes:
> Hi All,
>
> This patch wasn't included in the PowerPC fixes 5.7-4. Please add it.
It's not an important bug. I'll take the patch for v5.8
cheers
> On 29 April 2020 at 09:02 am, Nicholas Piggin wrote:
>> Christian reports:
>>
>> MODPOST vmlinux.o
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in
>> reference from the function .early_init_mmu() to the function
>> .init.text:.radix__early_init_mmu()
>> The function .early_init_mmu() references
>> the function __init .radix__early_init_mmu().
>> This is often because .early_init_mmu lacks a __init
>> annotation or the annotation of .radix__early_init_mmu is wrong.
>>
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x1ac): Section mismatch in
>> reference from the function .early_init_mmu() to the function
>> .init.text:.hash__early_init_mmu()
>> The function .early_init_mmu() references
>> the function __init .hash__early_init_mmu().
>> This is often because .early_init_mmu lacks a __init
>> annotation or the annotation of .hash__early_init_mmu is wrong.
>>
>> The compiler is uninlining early_init_mmu and not putting it in an init
>> section because there is no annotation. Add it.
>>
>> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>> Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>> ---
>> arch/powerpc/include/asm/book3s/64/mmu.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/book3s/64/mmu.h b/arch/powerpc/include/asm/book3s/64/mmu.h
>> index bb3deb76c951..3ffe5f967483 100644
>> --- a/arch/powerpc/include/asm/book3s/64/mmu.h
>> +++ b/arch/powerpc/include/asm/book3s/64/mmu.h
>> @@ -208,7 +208,7 @@ void hash__early_init_devtree(void);
>> void radix__early_init_devtree(void);
>> extern void hash__early_init_mmu(void);
>> extern void radix__early_init_mmu(void);
>> -static inline void early_init_mmu(void)
>> +static inline void __init early_init_mmu(void)
>> {
>> if (radix_enabled())
>> return radix__early_init_mmu();
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/64s: Fix early_init_mmu section mismatch
2020-05-18 2:40 ` Michael Ellerman
@ 2020-05-18 7:05 ` Christian Zigotzky
0 siblings, 0 replies; 5+ messages in thread
From: Christian Zigotzky @ 2020-05-18 7:05 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, Nicholas Piggin
OK, thanks.
> On 18. May 2020, at 04:40, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Christian Zigotzky <chzigotzky@xenosoft.de> writes:
>> Hi All,
>>
>> This patch wasn't included in the PowerPC fixes 5.7-4. Please add it.
>
> It's not an important bug. I'll take the patch for v5.8
>
> cheers
>
>>> On 29 April 2020 at 09:02 am, Nicholas Piggin wrote:
>>> Christian reports:
>>>
>>> MODPOST vmlinux.o
>>> WARNING: modpost: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in
>>> reference from the function .early_init_mmu() to the function
>>> .init.text:.radix__early_init_mmu()
>>> The function .early_init_mmu() references
>>> the function __init .radix__early_init_mmu().
>>> This is often because .early_init_mmu lacks a __init
>>> annotation or the annotation of .radix__early_init_mmu is wrong.
>>>
>>> WARNING: modpost: vmlinux.o(.text.unlikely+0x1ac): Section mismatch in
>>> reference from the function .early_init_mmu() to the function
>>> .init.text:.hash__early_init_mmu()
>>> The function .early_init_mmu() references
>>> the function __init .hash__early_init_mmu().
>>> This is often because .early_init_mmu lacks a __init
>>> annotation or the annotation of .hash__early_init_mmu is wrong.
>>>
>>> The compiler is uninlining early_init_mmu and not putting it in an init
>>> section because there is no annotation. Add it.
>>>
>>> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>>> Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>>> ---
>>> arch/powerpc/include/asm/book3s/64/mmu.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/powerpc/include/asm/book3s/64/mmu.h b/arch/powerpc/include/asm/book3s/64/mmu.h
>>> index bb3deb76c951..3ffe5f967483 100644
>>> --- a/arch/powerpc/include/asm/book3s/64/mmu.h
>>> +++ b/arch/powerpc/include/asm/book3s/64/mmu.h
>>> @@ -208,7 +208,7 @@ void hash__early_init_devtree(void);
>>> void radix__early_init_devtree(void);
>>> extern void hash__early_init_mmu(void);
>>> extern void radix__early_init_mmu(void);
>>> -static inline void early_init_mmu(void)
>>> +static inline void __init early_init_mmu(void)
>>> {
>>> if (radix_enabled())
>>> return radix__early_init_mmu();
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/64s: Fix early_init_mmu section mismatch
2020-04-29 7:02 [PATCH] powerpc/64s: Fix early_init_mmu section mismatch Nicholas Piggin
2020-05-17 10:12 ` Christian Zigotzky
@ 2020-06-09 5:29 ` Michael Ellerman
1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2020-06-09 5:29 UTC (permalink / raw)
To: linuxppc-dev, Nicholas Piggin; +Cc: Christian Zigotzky
On Wed, 29 Apr 2020 17:02:47 +1000, Nicholas Piggin wrote:
> Christian reports:
>
> MODPOST vmlinux.o
> WARNING: modpost: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in
> reference from the function .early_init_mmu() to the function
> .init.text:.radix__early_init_mmu()
> The function .early_init_mmu() references
> the function __init .radix__early_init_mmu().
> This is often because .early_init_mmu lacks a __init
> annotation or the annotation of .radix__early_init_mmu is wrong.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/64s: Fix early_init_mmu section mismatch
https://git.kernel.org/powerpc/c/9384e552aabb647ec22acb00181ca1715b0fcdfe
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-09 6:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-29 7:02 [PATCH] powerpc/64s: Fix early_init_mmu section mismatch Nicholas Piggin
2020-05-17 10:12 ` Christian Zigotzky
2020-05-18 2:40 ` Michael Ellerman
2020-05-18 7:05 ` Christian Zigotzky
2020-06-09 5:29 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).