* [PATCH kernel] cxl: Remove unused include
@ 2018-09-28 6:38 Alexey Kardashevskiy
2018-09-28 7:47 ` Andrew Donnellan
2018-09-28 12:46 ` Michael Ellerman
0 siblings, 2 replies; 5+ messages in thread
From: Alexey Kardashevskiy @ 2018-09-28 6:38 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Alexey Kardashevskiy, Frederic Barrat, Andrew Donnellan
The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
while it does not so let's remote it.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
drivers/misc/cxl/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index b66d832..8cbcbb7 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -17,7 +17,6 @@
#include <linux/pci.h>
#include <linux/of.h>
#include <linux/delay.h>
-#include <asm/opal.h>
#include <asm/msi_bitmap.h>
#include <asm/pnv-pci.h>
#include <asm/io.h>
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH kernel] cxl: Remove unused include
2018-09-28 6:38 [PATCH kernel] cxl: Remove unused include Alexey Kardashevskiy
@ 2018-09-28 7:47 ` Andrew Donnellan
2018-09-28 12:46 ` Michael Ellerman
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Donnellan @ 2018-09-28 7:47 UTC (permalink / raw)
To: Alexey Kardashevskiy, linuxppc-dev; +Cc: Frederic Barrat
On 28/9/18 4:38 pm, Alexey Kardashevskiy wrote:
> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
> while it does not so let's remote it.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Thanks for catching this
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
> drivers/misc/cxl/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index b66d832..8cbcbb7 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -17,7 +17,6 @@
> #include <linux/pci.h>
> #include <linux/of.h>
> #include <linux/delay.h>
> -#include <asm/opal.h>
> #include <asm/msi_bitmap.h>
> #include <asm/pnv-pci.h>
> #include <asm/io.h>
>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH kernel] cxl: Remove unused include
2018-09-28 6:38 [PATCH kernel] cxl: Remove unused include Alexey Kardashevskiy
2018-09-28 7:47 ` Andrew Donnellan
@ 2018-09-28 12:46 ` Michael Ellerman
2018-10-03 7:46 ` Alexey Kardashevskiy
1 sibling, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2018-09-28 12:46 UTC (permalink / raw)
To: Alexey Kardashevskiy, linuxppc-dev
Cc: Alexey Kardashevskiy, Andrew Donnellan, Frederic Barrat
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
> while it does not so let's remote it.
But it does use eg.
OPAL_PHB_CAPI_MODE_SNOOP_ON
OPAL_PHB_CAPI_MODE_CAPI
Which come from opal-api.h via opal.h.
So you should at least include opal-api.h.
cheers
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index b66d832..8cbcbb7 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -17,7 +17,6 @@
> #include <linux/pci.h>
> #include <linux/of.h>
> #include <linux/delay.h>
> -#include <asm/opal.h>
> #include <asm/msi_bitmap.h>
> #include <asm/pnv-pci.h>
> #include <asm/io.h>
> --
> 2.11.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH kernel] cxl: Remove unused include
2018-09-28 12:46 ` Michael Ellerman
@ 2018-10-03 7:46 ` Alexey Kardashevskiy
2018-10-03 8:29 ` Frederic Barrat
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Kardashevskiy @ 2018-10-03 7:46 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: Andrew Donnellan, Frederic Barrat
On 28/09/2018 22:46, Michael Ellerman wrote:
> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
>> while it does not so let's remote it.
>
> But it does use eg.
>
> OPAL_PHB_CAPI_MODE_SNOOP_ON
> OPAL_PHB_CAPI_MODE_CAPI
>
> Which come from opal-api.h via opal.h.
>
> So you should at least include opal-api.h.
I'd say that since it includes pnv-pci.h (and this is why this patch
compiles), it should be a different set of values for powernv (which
would map 1:1 to OPAL_PHB_xxx). The powernv platform knowledge is
already intimate enough for a driver to have. Dunno, I found this opal.h
inclusion confusing, that's all.
>
> cheers
>
>> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
>> index b66d832..8cbcbb7 100644
>> --- a/drivers/misc/cxl/pci.c
>> +++ b/drivers/misc/cxl/pci.c
>> @@ -17,7 +17,6 @@
>> #include <linux/pci.h>
>> #include <linux/of.h>
>> #include <linux/delay.h>
>> -#include <asm/opal.h>
>> #include <asm/msi_bitmap.h>
>> #include <asm/pnv-pci.h>
>> #include <asm/io.h>
>> --
>> 2.11.0
--
Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH kernel] cxl: Remove unused include
2018-10-03 7:46 ` Alexey Kardashevskiy
@ 2018-10-03 8:29 ` Frederic Barrat
0 siblings, 0 replies; 5+ messages in thread
From: Frederic Barrat @ 2018-10-03 8:29 UTC (permalink / raw)
To: linuxppc-dev
Le 03/10/2018 à 09:46, Alexey Kardashevskiy a écrit :
>
>
> On 28/09/2018 22:46, Michael Ellerman wrote:
>> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>>> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
>>> while it does not so let's remote it.
>>
>> But it does use eg.
>>
>> OPAL_PHB_CAPI_MODE_SNOOP_ON
>> OPAL_PHB_CAPI_MODE_CAPI
>>
>> Which come from opal-api.h via opal.h.
>>
>> So you should at least include opal-api.h.
>
>
> I'd say that since it includes pnv-pci.h (and this is why this patch
> compiles), it should be a different set of values for powernv (which
> would map 1:1 to OPAL_PHB_xxx). The powernv platform knowledge is
> already intimate enough for a driver to have. Dunno, I found this opal.h
> inclusion confusing, that's all.
I agree, it would be the cleaner way of doing it. It's going to be
pretty low on my list though...
Fred
>
>
>>
>> cheers
>>
>>> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
>>> index b66d832..8cbcbb7 100644
>>> --- a/drivers/misc/cxl/pci.c
>>> +++ b/drivers/misc/cxl/pci.c
>>> @@ -17,7 +17,6 @@
>>> #include <linux/pci.h>
>>> #include <linux/of.h>
>>> #include <linux/delay.h>
>>> -#include <asm/opal.h>
>>> #include <asm/msi_bitmap.h>
>>> #include <asm/pnv-pci.h>
>>> #include <asm/io.h>
>>> --
>>> 2.11.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-03 8:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 6:38 [PATCH kernel] cxl: Remove unused include Alexey Kardashevskiy
2018-09-28 7:47 ` Andrew Donnellan
2018-09-28 12:46 ` Michael Ellerman
2018-10-03 7:46 ` Alexey Kardashevskiy
2018-10-03 8:29 ` Frederic Barrat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).