* [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type
@ 2019-10-29 3:40 Saurav Girepunje
2019-10-29 4:17 ` Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2019-10-29 3:40 UTC (permalink / raw)
To: benh, paulus, mpe, groug, clg, christophe.jaillet, tglx,
saurav.girepunje, linuxppc-dev, linux-kernel
Cc: saurav.girepunje
Use true/false for bool return type in xive_spapr_cleanup_queue
function.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
arch/powerpc/sysdev/xive/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c
index 33c10749edec..74e3ffae0be6 100644
--- a/arch/powerpc/sysdev/xive/spapr.c
+++ b/arch/powerpc/sysdev/xive/spapr.c
@@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc,
static bool xive_spapr_match(struct device_node *node)
{
/* Ignore cascaded controllers for the moment */
- return 1;
+ return true;
}
#ifdef CONFIG_SMP
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type
2019-10-29 3:40 [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type Saurav Girepunje
@ 2019-10-29 4:17 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-10-29 4:17 UTC (permalink / raw)
To: Saurav Girepunje, benh, paulus, mpe, groug, clg,
christophe.jaillet, tglx, linuxppc-dev, linux-kernel
Cc: saurav.girepunje
This is not actually a 'fix'
I suggest you to rephrase the subject in a different way and
remove the word 'fix' from it.
On 10/28/19 22:40, Saurav Girepunje wrote:
> Use true/false for bool return type in xive_spapr_cleanup_queue
> function.
>
How do you find this?
If you used a tool to find this, please mention it.
Thanks
--
Gustavo
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> arch/powerpc/sysdev/xive/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c
> index 33c10749edec..74e3ffae0be6 100644
> --- a/arch/powerpc/sysdev/xive/spapr.c
> +++ b/arch/powerpc/sysdev/xive/spapr.c
> @@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc,
> static bool xive_spapr_match(struct device_node *node)
> {
> /* Ignore cascaded controllers for the moment */
> - return 1;
> + return true;
> }
>
> #ifdef CONFIG_SMP
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-29 4:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 3:40 [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type Saurav Girepunje
2019-10-29 4:17 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).