From: Andrew Donnellan <ajd@linux.ibm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cxl: Use of_property_ accessor functions
Date: Tue, 13 Aug 2024 21:06:03 +1000 [thread overview]
Message-ID: <0ff6502cda3c0a8e1da6bcb0e93c57bf79e0d822.camel@linux.ibm.com> (raw)
In-Reply-To: <20240729-dt-cxl-cleanup-v1-2-a75eea80d231@kernel.org>
On Mon, 2024-07-29 at 16:36 -0600, Rob Herring (Arm) wrote:
> The CXL driver has its own custom implementations of typed DT
> property
> accessors. Replace the custom property accessor functions with the
> common DT property functions.
>
> This clean-up is part of a larger effort to remove of_get_property()
> and
> other DT functions which leak pointers to DT node and property data.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
This patch leaves two uses of of_get_property() (in read_phys_addr()
and read_adapter_irq_config()) - are you planning to get rid of those
in a future patch?
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
prev parent reply other threads:[~2024-08-13 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 22:36 [PATCH 0/2] cxl: DT property accessor cleanups Rob Herring (Arm)
2024-07-29 22:36 ` [PATCH 1/2] cxl: Drop printing of DT properties Rob Herring (Arm)
2024-08-13 10:14 ` Andrew Donnellan
2024-07-29 22:36 ` [PATCH 2/2] cxl: Use of_property_ accessor functions Rob Herring (Arm)
2024-08-13 11:06 ` Andrew Donnellan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ff6502cda3c0a8e1da6bcb0e93c57bf79e0d822.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=fbarrat@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).