From: "Stephen Williams" <612dlag102@sneakemail.com>
To: linuxppc-embedded@lists.linuxppc.org
Subject: SystemACE, but I'm not a V2Pro
Date: Sun, 21 Mar 2004 18:00:13 -0800 [thread overview]
Message-ID: <10183-36126@sneakemail.com> (raw)
I'm successfully using the existing System ACE adapter driver
to mount my compact flash devices, and that's great. But I'm
getting some baggage I don't want. Specifically, in adapter.c
the xsysace_init function replaces the ppc_md.restart function
with xsysace_restart, which breaks reboot on my PPC405GPr based
board.
The brute force method is for me to #ifdef out that bit of
code with something like "#ifndef CONFIG_JSE" (my board is
a JSE board) but that seems klunky.
It seems to me there may be others who have SystemACE boards
without V2Pro chips. Would it be safe and reasonable for me
to use the CONFIG_VIRTEX_II_PRO config define to ifdef that
bit of code *in*?
(I'm asking because I'd like to integrate my board support
into the main tree someday, so I want a generally clean patch.)
--
Steve Williams "The woods are lovely, dark and deep.
steve at XXXXXXXXXX But I have promises to keep,
http://www.XXXXXXXXXX and lines to code before I sleep,
http://www.picturel.com And lines to code before I sleep."
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next reply other threads:[~2004-03-22 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 2:00 Stephen Williams [this message]
2004-03-22 15:17 ` SystemACE, but I'm not a V2Pro Jeff Angielski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10183-36126@sneakemail.com \
--to=612dlag102@sneakemail.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).