From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paul Mackerras <paulus@samba.org>,
Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [PATCH] Mac/m68k ADB HID
Date: 10 Jun 2003 09:22:42 +0200 [thread overview]
Message-ID: <1055229762.642.51.camel@gaston> (raw)
In-Reply-To: <Pine.GSO.4.21.0306091731290.1347-100000@vervain.sonytel.be>
On Mon, 2003-06-09 at 17:32, Geert Uytterhoeven wrote:
> Hi,
>
> Is this OK for you? It fixes compilation for Mac/m68k.
Looks ok, though I'd rather use Paul's new CONFIG_PPC_PMAC
here.
> ---
>
> ADB HID: Exclude PowerMac-specific things on classic Macs
>
> --- linux-2.5.x/drivers/macintosh/adbhid.c Tue May 27 19:02:52 2003
> +++ linux-m68k-2.5.x/drivers/macintosh/adbhid.c Sun Jun 8 11:10:58 2003
> @@ -44,7 +44,9 @@
> #include <linux/pmu.h>
>
> #include <asm/machdep.h>
> +#ifdef CONFIG_PPC
> #include <asm/pmac_feature.h>
> +#endif
>
> #ifdef CONFIG_PMAC_BACKLIGHT
> #include <asm/backlight.h>
> @@ -160,6 +162,7 @@
> return;
> case 0x3f: /* ignore Powerbook Fn key */
> return;
> +#ifdef CONFIG_PPC
> case 0x7e: /* Power key on PBook 3400 needs remapping */
> switch(pmac_call_feature(PMAC_FTR_GET_MB_INFO,
> NULL, PMAC_MB_INFO_MODEL, 0)) {
> @@ -169,6 +172,7 @@
> keycode = 0x7f;
> }
> break;
> +#endif /* CONFIG_PPC */
> }
>
> if (adbhid[id]->keycode[keycode]) {
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-06-10 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-09 15:32 [PATCH] Mac/m68k ADB HID Geert Uytterhoeven
2003-06-10 7:22 ` Benjamin Herrenschmidt [this message]
2003-06-10 7:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055229762.642.51.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).