From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Miles Lane <miles.lane@comcast.net>, linuxppc-dev@lists.linuxppc.org
Subject: Re: linuxppc-2.5 (rsync mvista) -- drivers/input/evdev.c:243: error: invalid lvalue in asm statement
Date: 03 Aug 2003 13:31:24 +0200 [thread overview]
Message-ID: <1059910283.3519.121.camel@gaston> (raw)
In-Reply-To: <16172.61621.985947.378822@cargo.ozlabs.ibm.com>
On Sun, 2003-08-03 at 13:23, Paul Mackerras wrote:
> Miles Lane writes:
> >
> > CC drivers/input/evdev.o
> > drivers/input/evdev.c: In function `evdev_ioctl':
> > drivers/input/evdev.c:243: error: invalid lvalue in asm statement
> > drivers/input/evdev.c:243: error: invalid lvalue in asm statement
> > drivers/input/evdev.c:243: error: invalid lvalue in asm statement
> > drivers/input/evdev.c:243: error: invalid lvalue in asm statement
>
> These errors are a consequence of the change I made to make get_user
> work on 64-bit quantities. I can't actually see a way to have
> get_user work when it's used the way it is here and also work on
> 64-bit quantities, without giving spurious warnings when used on
> pointers.
>
> Who was it that wanted 64-bit get_user? I think we are going to have
> to make a separate get_user64().
No Paul, it's not your fault, if you look closely at evdev, that code
can't really work properly anyway.
I talked to Vojtech at OLS and he'll be fixing that to always pass
either an u32 or an int to userspace.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-08-03 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 1:23 linuxppc-2.5 (rsync mvista) -- drivers/input/evdev.c:243: error: invalid lvalue in asm statement Miles Lane
2003-08-03 9:13 ` Benjamin Herrenschmidt
2003-08-03 11:23 ` Paul Mackerras
2003-08-03 11:31 ` Benjamin Herrenschmidt [this message]
2003-08-04 8:49 ` Franz Sirl
2003-08-04 9:42 ` Benjamin Herrenschmidt
2003-08-04 11:24 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059910283.3519.121.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=miles.lane@comcast.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).