LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Rosen Penev <rosenp@gmail.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Linus Walleij <linusw@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv2] powerpc/44x: Set GPIO chip parent
Date: Thu, 30 Jul 2026 07:45:53 +0200	[thread overview]
Message-ID: <1062ee0c-cf44-479e-a442-3dfda7d7614f@kernel.org> (raw)
In-Reply-To: <CAKxU2N-i02g0jJaiJ+GzX1iQ8_W=uX0iMpmeNw=0=u-xU7tkLg@mail.gmail.com>



Le 17/07/2026 à 21:05, Rosen Penev a écrit :
> On Sat, May 16, 2026 at 11:38 PM Rosen Penev <rosenp@gmail.com> wrote:
>>
>> The PPC4xx GPIO driver stopped assigning an explicit parent
>> to the gpio_chip when it moved away from of_mm_gpiochip_add_data().
>>
>> Restore that association from the platform device so OF GPIO lookup
>> can match phandles to the registered gpiochip.
>>
>> Tested on: Cisco MX60W. No more probe deferral.
>>
>> Assisted-by: Codex:GPT-5.5
>> Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
> Did I forget to ping someone?

Probably not, but afterwards you sent your series which moves the driver 
into drivers/gpio/ and which does the same, so this one was flagged 
"superseeded" in Patchwork 
(https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260517063754.21819-1-rosenp@gmail.com/)

I put it back to 'new'. Maddy, can you pick it up ?

Christophe


>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>> ---
>>   arch/powerpc/platforms/44x/gpio.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
>> index aea0d913b59d..4413a94cf7a6 100644
>> --- a/arch/powerpc/platforms/44x/gpio.c
>> +++ b/arch/powerpc/platforms/44x/gpio.c
>> @@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)
>>
>>          gc = &chip->gc;
>>
>> +       gc->parent = dev;
>>          gc->base = -1;
>>          gc->ngpio = 32;
>>          gc->direction_input = ppc4xx_gpio_dir_in;
>> --
>> 2.54.0
>>



      reply	other threads:[~2026-07-30  5:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17  6:37 [PATCHv2] powerpc/44x: Set GPIO chip parent Rosen Penev
2026-05-17 10:47 ` Linus Walleij
2026-05-20 13:15 ` Christophe Leroy (CS GROUP)
2026-07-17 19:05 ` Rosen Penev
2026-07-30  5:45   ` Christophe Leroy (CS GROUP) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1062ee0c-cf44-479e-a442-3dfda7d7614f@kernel.org \
    --to=chleroy@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox