linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kauai ATA for G4 windtunnel
@ 2004-01-03 18:24 Samuel Rydh
  2004-01-03 22:59 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Rydh @ 2004-01-03 18:24 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: benh


Hi,

The kauai ATA support in the 2.5 linuxppc tree for the G4 windtunnel is currently
broken due to a missing PCI id. The pci_ids.h file defines PCI_DEVICE_ID_APPLE_KAUAI_ATA
to be 0x3b while the actual hardware (in my machine) has id 0x33.

The following patch fixes the problem (although the define should of course be pushed to
pci_ids.h).


===== drivers/ide/ppc/pmac.c 1.25 vs edited =====
--- 1.25/drivers/ide/ppc/pmac.c	Mon Sep  1 00:49:53 2003
+++ edited/drivers/ide/ppc/pmac.c	Sat Jan  3 18:27:32 2004
@@ -1439,8 +1439,10 @@
 	.resume		= pmac_ide_macio_resume,
 };

+#define PCI_DEVICE_ID_APPLE_KAUAI_G4WT_ATA 0x33
 static struct pci_device_id pmac_ide_pci_match[] __devinitdata = {
 	{ PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_KAUAI_ATA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+	{ PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_KAUAI_G4WT_ATA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
 };

 static struct pci_driver pmac_ide_pci_driver = {


/Samuel

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kauai ATA for G4 windtunnel
  2004-01-03 18:24 [PATCH] kauai ATA for G4 windtunnel Samuel Rydh
@ 2004-01-03 22:59 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2004-01-03 22:59 UTC (permalink / raw)
  To: Samuel Rydh; +Cc: linuxppc-dev list


On Sun, 2004-01-04 at 05:24, Samuel Rydh wrote:
> Hi,
>
> The kauai ATA support in the 2.5 linuxppc tree for the G4 windtunnel is currently
> broken due to a missing PCI id. The pci_ids.h file defines PCI_DEVICE_ID_APPLE_KAUAI_ATA
> to be 0x3b while the actual hardware (in my machine) has id 0x33.
>
> The following patch fixes the problem (although the define should of course be pushed to
> pci_ids.h).
>

Hi ! This has already been fixed for a long time in my tree
(bk://ppc.bkbits.net/linuxppc-2.5-benh or rsync mirror on
source.mvista.org)

I expect to have all of that stuff merged with Andrew soon, I admit not
bothering much updating linuxppc-2.5 lately...

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-01-03 22:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-03 18:24 [PATCH] kauai ATA for G4 windtunnel Samuel Rydh
2004-01-03 22:59 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).