From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Michael Schmitz <schmitz@zirkon.biophys.uni-duesseldorf.de>,
"David D. Kilzer" <ddkilzer@kilzer.net>,
linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [PATCH] Fix byte-swapped ethernet addr for Asante Fast 10/100 PCI Adapter
Date: Sun, 25 Jan 2004 12:48:38 +1100 [thread overview]
Message-ID: <1074995318.835.129.camel@gaston> (raw)
In-Reply-To: <40132070.4080704@pobox.com>
On Sun, 2004-01-25 at 12:48, Jeff Garzik wrote:
> Geert Uytterhoeven wrote:
> > On Tue, 23 Dec 2003, Michael Schmitz wrote:
> >>I'm not sure - the card having an OF driver might mean it's a Mac card,
> >>needing byte swapping, whereas a card with no OF driver would be a PC
> >>card, needing no byte swap. Or vice versa. Asante probably never built PC
> >>specific ethernet cards so the PCI vendor/device property could be used
> >>instead of OF data. OF data is just easier to get at :-)
> >
> >
> > Really? I'd say it's easier to look at the struct pci_dev the Tulip driver
> > already looks at. Besides, someone may want to try that card in a non-PowerMac,
> > while still having the correct MAC address.
>
>
> Agreed.
Provided the card has a unique device ID... but yes, in this case,
it's the best solution.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-01-25 1:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-07 6:21 [PATCH] Fix byte-swapped ethernet addr for Asante Fast 10/100 PCI Adapter David D. Kilzer
2003-12-22 14:27 ` Michael Schmitz
2003-12-23 0:05 ` Benjamin Herrenschmidt
2003-12-23 13:15 ` David D. Kilzer
2003-12-23 13:26 ` Benjamin Herrenschmidt
2003-12-23 13:30 ` Michael Schmitz
2003-12-23 14:01 ` Geert Uytterhoeven
2003-12-23 14:32 ` Michael Schmitz
2003-12-23 15:06 ` David D. Kilzer
2004-01-25 1:48 ` Jeff Garzik
2004-01-25 1:48 ` Benjamin Herrenschmidt [this message]
2004-02-02 5:49 ` David D. Kilzer
2004-02-05 14:46 ` David D. Kilzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074995318.835.129.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ddkilzer@kilzer.net \
--cc=geert@linux-m68k.org \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=schmitz@zirkon.biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).