diff between radeonfb.c and aty/radeon_base.c

diff between radeonfb.c and aty/radeon_base.c

[Cedric Pradalier]

Hi,

	In dual-headed mode (no problem in single head), on my ibook2.2, I'm
experiencing the yellowish tint bug with some part of X. After googling,
I looked for the newmode.surface_cntl line in radeonfb, and I found a
strange copy-paste between radeonfb.c and aty/radeon_base.c (I use 2.6.5
kernel).
In radeon_base.c :
	/*
	 * It looks like recent chips have a problem with SURFACE_CNTL,
	 * setting SURF_TRANSLATION_DIS completely disables the
	 * swapper as well, so we leave it unset now.
	 */
	newmode.surface_cntl = 0;

#if defined(__BIG_ENDIAN)

In radeonfb.c :

#if defined(__BIG_ENDIAN)
	/*
	 * It looks like recent chips have a problem with SURFACE_CNTL,
	 * setting SURF_TRANSLATION_DIS completely disables the
	 * swapper as well, so we leave it unset now.
	 */
	newmode.surface_cntl = 0;

Note the ordering difference between ifdef and surface_cntl=0.

Is this normal ? As far as i can see, this means that surface_cntl is
not initialized on ibook with radeonfb.

I'll try to change and report.

--
Cedric

"[Of course] I'm French! Why do think I have this outrageous
accent, you silly king-a?!"  Monty Python and the Holy Grail

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: diff between radeonfb.c and aty/radeon_base.c

[Benjamin Herrenschmidt]

> Note the ordering difference between ifdef and surface_cntl=0.
>
> Is this normal ? As far as i can see, this means that surface_cntl is
> not initialized on ibook with radeonfb.

iBooks have __BIG_ENDIAN set ;)

> I'll try to change and report.

The yellowish tint is an XFree bug afaik, are you using the DRI snapshots ?
They have a fix.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: diff between radeonfb.c and aty/radeon_base.c

[Cedric Pradalier]

According to Benjamin Herrenschmidt, on Thu, 13 May 2004 14:29:09 +1000,

>
>> Note the ordering difference between ifdef and surface_cntl=0.
>>
>> Is this normal ? As far as i can see, this means that surface_cntl is
>> not initialized on ibook with radeonfb.
>
>iBooks have __BIG_ENDIAN set ;)

Oops. I'll think I'll never get use to the meaning of this big and
little.

>
>> I'll try to change and report.
>
>The yellowish tint is an XFree bug afaik,

Oh, I understood they where linked to the radeonfb surface_cntl
parameter in my archive browsing. Anyway, the report is that as
expected, this does not change anything.

> are you using the DRI snapshots ? They have a fix.

I'm using M. Daenzer dri-trunk server and the patch to read PLL values
from openfirmware. The strange thing is  that the yellowish tint only
appear in dual-headed mode (bi-display or xinerama) with dri disabled.
No problem in mergedfb mode where dri is enabled.

So I guess there is an initialization in dri which is needed in non-dri
mode. I'll try to have a look at that.

>
>Ben.
>
>
>


--
Cedric

"[Of course] I'm French! Why do think I have this outrageous
accent, you silly king-a?!"  Monty Python and the Holy Grail

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/