netconsole & sungem

netconsole & sungem

[Colin Leroy]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi,

I tried to make netconsole work (with the attached patch copied from e1000), but can't get anything on the cable... the destination station doesn't see anything (nor Ethereal).

Are there any traps I didn't see ? (I have netconsole as a module and it loads ok:
netconsole: local port 32768
netconsole: interface eth0
netconsole: remote port 6666
netconsole: remote IP 192.168.0.4
netconsole: remote ethernet address 08:00:20:76:3c:57
netconsole: local IP 192.168.0.11
netconsole: network logging started
)

TIA,
--
Colin

[-- Attachment #2: sungem.diff --]
[-- Type: text/plain, Size: 962 bytes --]

--- drivers/net/sungem.c.orig	2004-05-19 20:47:15.000000000 +0200
+++ drivers/net/sungem.c	2004-05-19 22:09:25.920632936 +0200
@@ -2441,6 +2441,22 @@
 	return 0;
 }

+#ifdef CONFIG_NET_POLL_CONTROLLER
+/*
+ * Polling 'interrupt' - used by things like netconsole to send skbs
+ * without having to re-enable interrupts. It's not called while
+ * the interrupt routine is executing.
+ */
+
+static void gem_poll(struct net_device *dev)
+{
+	struct gem *gp = dev->priv;
+	disable_irq(gp->pdev->irq);
+	gem_interrupt(gp->pdev->irq, (void *)dev, NULL);
+	enable_irq(gp->pdev->irq);
+}
+#endif
+
 static int gem_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
 	struct gem *gp = dev->priv;
@@ -2810,6 +2826,9 @@
 	dev->change_mtu = gem_change_mtu;
 	dev->irq = pdev->irq;
 	dev->dma = 0;
+#ifdef CONFIG_NET_POLL_CONTROLLER
+	dev->poll_controller = gem_poll;
+#endif

 	if (register_netdev(dev)) {
 		printk(KERN_ERR PFX "Cannot register net device, "

Re: netconsole & sungem

[Benjamin Herrenschmidt]

On Thu, 2004-05-20 at 06:10, Colin Leroy wrote:
> Hi,
>
> I tried to make netconsole work (with the attached patch copied from e1000), but can't get anything on the cable... the destination station doesn't see anything (nor Ethereal).
>
> Are there any traps I didn't see ? (I have netconsole as a module and it loads ok:
> netconsole: local port 32768
> netconsole: interface eth0
> netconsole: remote port 6666
> netconsole: remote IP 192.168.0.4
> netconsole: remote ethernet address 08:00:20:76:3c:57
> netconsole: local IP 192.168.0.11
> netconsole: network logging started
> )

I have to look more closely at netconsole, does it actually call open() on
the driver ? If not, beware that sungem will power manage the chip when closed,
also the link state machine may not have had time to run...

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: netconsole & sungem

[Colin Leroy]

On 20 May 2004 at 07h05, Benjamin Herrenschmidt wrote:

Hi,

> I have to look more closely at netconsole, does it actually call open() on
> the driver ? If not, beware that sungem will power manage the chip when
> closed,

Well, it doesn't look like (it seems to me that all the init stuff is done
in net/core/netpoll.c::netpoll_setup()).
During my tests, I used modules for sungem and netconsole, and I'm actually quite sure that the chip was up, as I had an ssh session to the remote host... I also tried to issue some stuff via 'netcat -u 192.168.0.4 6666' and it worked. It only looks like the netconsole/netpoll isn't sending anything.

> also the link state machine may not have had time to run...

Shouldn't be a problem neither, as everything is already up when I do my tests.

I'll try find more about all this.

Thanks,
--
Colin

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/