From: David Woodhouse <dwmw2@infradead.org>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: Dieu Morales <dieumorales@yahoo.com>,
linuxppc-embedded@lists.linuxppc.org,
Brian Waite <waite@skycomputers.com>
Subject: Re: GT64260_eth (Ethernet) Driver
Date: Sat, 26 Jun 2004 00:43:20 +0100 [thread overview]
Message-ID: <1088207000.4636.136.camel@imladris.demon.co.uk> (raw)
In-Reply-To: <40DCA1A3.6000401@mvista.com>
On Fri, 2004-06-25 at 15:05 -0700, Mark A. Greer wrote:
> Would you mind looking at the code, giving me feedback ("this totally
> sucks and needs to be thrown out" is perfectly valid) and looking for
> things I may have missed?
For one, pci_auto sucks and needs to be thrown out. If the generic Linux
PCI resource assignment is broken, fix it rather than reimplementing it.
I'd also like to ditch the typedefs (use struct mv64x60_setup_info
instead of mv64x60_setup_info_t etc.).
Further than that I haven't noticed much yet -- my Friday ended before I
got the machine to boot. I think I relocated the chip to the wrong
address, because first the memory probe returned zero and then the PCI
idents were all 0xFFFF. I'll play some more on Monday.
Thanks for the pointers.
--
dwmw2
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-25 23:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-20 20:27 GT64260_eth (Ethernet) Driver Dieu Morales
2004-06-23 22:39 ` Mark A. Greer
2004-06-24 8:37 ` David Woodhouse
2004-06-24 11:23 ` Brian Waite
2004-06-24 18:46 ` Mark A. Greer
2004-06-24 19:02 ` Mark A. Greer
2004-06-25 7:10 ` David Woodhouse
2004-06-25 22:05 ` Mark A. Greer
2004-06-25 23:43 ` David Woodhouse [this message]
2004-06-26 0:07 ` Mark A. Greer
2004-06-26 0:41 ` Paul Mackerras
2004-06-26 1:47 ` Mark A. Greer
2004-07-29 3:19 ` Dieu Morales
2004-07-29 17:28 ` Mark A. Greer
2004-06-29 14:08 ` David Woodhouse
2004-06-29 15:23 ` BAT mapping Linh Dang
2004-06-29 17:59 ` Linh Dang
-- strict thread matches above, loose matches on Subject: below --
2005-09-19 18:53 GT64260_eth (Ethernet) Driver Earl Olsen
2005-09-20 16:02 Earl Olsen
2005-09-20 17:13 ` Brian Waite
2005-09-20 18:32 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088207000.4636.136.camel@imladris.demon.co.uk \
--to=dwmw2@infradead.org \
--cc=dieumorales@yahoo.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=mgreer@mvista.com \
--cc=waite@skycomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).