From: Matthew McClintock <mcclintock@freescale.com>
To: Sylvain Munaut <tnt@246tnt.com>
Cc: Adrian Cox <adrian@humboldt.co.uk>,
Embedded Linux PPC list <linuxppc-embedded@lists.linuxppc.org>,
"Kumar K. Gala" <kumar.gala@motorola.com>,
Matthew McClintock <mcclintock@motorola.com>
Subject: Re: [PATCH][RFC]Updated MPC I2C driver
Date: Thu, 01 Jul 2004 15:48:07 +0000 [thread overview]
Message-ID: <1088696887.7555.70.camel@matthew-laptop> (raw)
In-Reply-To: <40E463E5.1060401@246tNt.com>
The blocks look very similar, you might want to look at the follow up
patch I just sent that abstracts the read/writes. It might be as simple
as abstracting another read/write function for your particular platform.
Regards,
Matthew
On Thu, 2004-07-01 at 19:20, Sylvain Munaut wrote:
> Adrian Cox wrote:
>
> > This version should support MPC8540 as well as MPC8245 and MPC107.
> > I don't have MPC85xx hardware, so I'd like feedback from people who
> > do.
> >
> > To use it on MPC107/824x requires the OCP patch that went by on the
> > list on Tuesday. The support for MPC85xx is already in the kernel.
> >
> > If nobody has any complaints I'm ready to send it to Greg K-H.
>
>
> Interesting, it really looks like the MPC5200 I2C controller.
> Unfortunatly :
> - On the MPC5200, all the status/controls bits are in the MSBs ( so
> the consts would need to be << 24 )
> - And there is a interrupt control register I don't see in your code.
> It's shared by the two I2C controllers onboard.
>
> I'll try to see if I can make it work on the lite5200 board.
>
> Sylvain Munaut
--
Matthew McClintock <mcclintock@freescale.com>
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-07-01 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 18:19 [PATCH][RFC]Updated MPC I2C driver Adrian Cox
2004-07-01 14:59 ` Matthew McClintock
2004-07-01 21:25 ` Adrian Cox
2004-07-01 22:32 ` Sylvain Munaut
2004-07-02 9:05 ` Adrian Cox
2004-07-02 11:01 ` Sylvain Munaut
2004-07-02 13:44 ` Adrian Cox
2004-07-02 15:11 ` Sylvain Munaut
2004-07-01 18:59 ` Eugene Surovegin
2004-07-01 19:20 ` Sylvain Munaut
2004-07-01 15:48 ` Matthew McClintock [this message]
2004-07-01 21:07 ` Sylvain Munaut
2004-07-01 20:54 ` Adrian Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088696887.7555.70.camel@matthew-laptop \
--to=mcclintock@freescale.com \
--cc=adrian@humboldt.co.uk \
--cc=kumar.gala@motorola.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=mcclintock@motorola.com \
--cc=tnt@246tnt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).