[PATCH] md raid autodetection on mac partitions

[PATCH] md raid autodetection on mac partitions

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi!

It took me some time to discover that there is no provision in the mac
parition handling code for autodetection of md raid arrays.

Is there any particular reason why this isn't implemented?

I've now added a new partition type 'Linux_raid_autodetect', which can
be used for md autodetect.

Please consider inclusion of this patch.

--
- Harald Welte <laforge@gnumonks.org>               http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

[-- Attachment #2: linux-2.6.8-mac-autoraid.patch --]
[-- Type: text/plain, Size: 765 bytes --]

--- linux-2.6.8-rc3-plain/fs/partitions/mac.c	2004-08-05 19:49:30.000000000 +0200
+++ linux-2.6.8-rc3-hw1/fs/partitions/mac.c	2004-08-05 19:52:06.000000000 +0200
@@ -4,6 +4,10 @@
  *  Code extracted from drivers/block/genhd.c
  *  Copyright (C) 1991-1998  Linus Torvalds
  *  Re-organised Feb 1998 Russell King
+ *
+ *  2004-08-05 Harald Welte <laforge@gnumonks.org>:
+ *  	- Add support for md-raid autodetection to make md-raid bootable
+ *	  (Partition type "Linux_raid_autodetect")
  */

 #include <linux/config.h>
@@ -110,6 +114,9 @@
 					goodness--;
 			}

+			if (strcasecmp(part->type, "Linux_raid_autodetect") == 0)
+				state->parts[slot].flags = 1;
+
 			if (goodness > found_root_goodness) {
 				found_root = blk;
 				found_root_goodness = goodness;

Re: [PATCH] md raid autodetection on mac partitions

[Christoph Hellwig]

On Fri, Aug 06, 2004 at 09:59:18AM +0200, Harald Welte wrote:
> Hi!
>
> It took me some time to discover that there is no provision in the mac
> parition handling code for autodetection of md raid arrays.
>
> Is there any particular reason why this isn't implemented?
>
> I've now added a new partition type 'Linux_raid_autodetect', which can
> be used for md autodetect.
>
> Please consider inclusion of this patch.

No.   raid autodetection is deprectaed, we don't want it for more
partiton types.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] md raid autodetection on mac partitions

[Harald Welte]

On Sat, Aug 07, 2004 at 01:04:04PM +0200, Christoph Hellwig wrote:

> No.   raid autodetection is deprectaed, we don't want it for more
> partiton types.

Oh well.  I guess I'm the only user who likes to boot his machine
without building some initrd - especially since this never works out of
the box with any vendor-supplied tools on any distribution I've tried
so far.

If autodetection is deprecated, will we at least see some kernel boot
option, where one could specify which partitions to use?

--
- Harald Welte <laforge@gnumonks.org>               http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] md raid autodetection on mac partitions

[Benjamin Herrenschmidt]

On Fri, 2004-08-06 at 17:59, Harald Welte wrote:
> Hi!
>
> It took me some time to discover that there is no provision in the mac
> parition handling code for autodetection of md raid arrays.
>
> Is there any particular reason why this isn't implemented?
>
> I've now added a new partition type 'Linux_raid_autodetect', which can
> be used for md autodetect.

Hi Harald, just found this patch, sorry for the delay.

Why just not "Linux_raid" ?

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/