From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Colin Leroy <colin@colino.net>
Cc: Linux PPC Dev <linuxppc-dev@ozlabs.org>
Subject: Re: hda errors on iBook G4
Date: Sat, 23 Oct 2004 09:30:56 +1000 [thread overview]
Message-ID: <1098487856.19462.93.camel@gaston> (raw)
In-Reply-To: <20041022175923.21b11f18.colin@colino.net>
On Sat, 2004-10-23 at 01:59, Colin Leroy wrote:
> On 22 Oct 2004 at 17h10, Colin Leroy wrote:
>
> Hi,
>
> > I noticed hda status errors in my iBook G4's dmesg quite a long time
> > ago, but never looked any more... Today I just ran tests with hdparm
> > and this looks like really reproduceable:
>
> I found one strange thing in drivers/ide/ppc/pmac.c:
>
> pmac_ide_do_setfeature(ide_drive_t *drive, u8 command) {...}
>
> pmac_ide_udma_enable(ide_drive_t *drive, u16 mode)
> {...
> ret = pmac_ide_do_setfeature(drive, mode);
> ...}
>
> We really want to pass u16 to the function taking an u8 arg?
> (just a wild shot, it's probably wanted, but i thought i'd share).
It's a thinko, but it's always a u8 anyway
Ben.
next prev parent reply other threads:[~2004-10-22 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 15:30 hda errors on iBook G4 Colin Leroy
2004-10-22 15:59 ` Colin Leroy
2004-10-22 23:30 ` Benjamin Herrenschmidt [this message]
2004-10-22 23:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098487856.19462.93.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=colin@colino.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).