Re: Test patch for sleep on Aluminium PowerBooks

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Wed, 2004-10-27 at 19:50 +1000, Benjamin Herrenschmidt wrote:
> Hi !
> 
> This is an experimental patch against 2.6.9. It concerns the ATI based
> Aluminium PowerBook. The nVidia based ones aren't concerned at all, and
> the iBook G4 will have to wait a bit more for me to get the video wakeup
> code right.

Works for me, thanks. Works better if I have the attached patch too. 

Xorg doesn't seem to receive mouse events from the USB mouse after
resume, but 'od -t x1 /dev/input/mice' does continue to work after
resume. I'll investigate that one further.

-- 
dwmw2

[-- Attachment #2: linux-2.6.9-usbsuspend.patch --]
[-- Type: text/x-patch, Size: 618 bytes --]

--- linux-2.6.9/drivers/usb/core/hub.c.susp	2004-10-27 17:30:39.796999176 +0100
+++ linux-2.6.9/drivers/usb/core/hub.c	2004-10-27 17:31:49.991979112 +0100
@@ -1527,12 +1527,12 @@ static int __usb_suspend_device (struct 
 			 * even for drivers that can't suspend.
 			 */
 			if (!driver->suspend || state > PM_SUSPEND_MEM) {
-#if 1
+#if 0
 				dev_warn(&intf->dev, "resume is unsafe!\n");
 #else
-				down_write(&usb_bus_type.rwsem);
+				down_write(&usb_bus_type.subsys.rwsem);
 				device_release_driver(&intf->dev);
-				up_write(&usb_bus_type.rwsem);
+				up_write(&usb_bus_type.subsys.rwsem);
 #endif
 			}
 		}