From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FC8FC001DE for ; Tue, 25 Jul 2023 20:52:44 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kBoM0QDD; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R9TkM0MxWz3cXT for ; Wed, 26 Jul 2023 06:52:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kBoM0QDD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R9TjG0YxNz3bZv for ; Wed, 26 Jul 2023 06:51:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=BI6vld8daiZZqGCYXywTiEB06qS0pOcYQzPLq+kIgpA=; b=kBoM0QDDYWvRihqO9OYZiObhMj GlyRzTCZ7/WdvW06YOS6WhtEsgXu4P1dKW10wb/QbeKXBO9YvNSYtgD9VbSTzkwB612KtZK3+NKZL PUCberLDUcsiNFgFwoVPx1l3HnofLB9hYRk0dGE1wJYC/WBqIRrlZGzJxeCWlpE/oM/6a8jfZLd2g A20JUg5vvH4JUfv17i+QZRPSFeyFT74AQc8YT84WpVzZ3L4JbMNVTsJtZRXTSqPKDs3fi93vJfSuq p0PQYB8/Rg0lTnL28cf9yteCsl9N6+X6L1vjKxXoTcp+pM4nbyjbr8AEp1iNmusW8JYUFcNJaqS+G ryDERQsA==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qOP0M-008Te2-2y; Tue, 25 Jul 2023 20:51:40 +0000 Message-ID: <10fbf60c-f7fe-d2ca-3d16-488453a88889@infradead.org> Date: Tue, 25 Jul 2023 13:51:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] Documentation: devices.txt: reconcile serial/ucc_uart minor numers Content-Language: en-US To: Timur Tabi References: <20230724063341.28198-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Slaby , Jonathan Corbet , Greg Kroah-Hartman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Kumar Gala , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 7/25/23 13:38, Timur Tabi wrote: > On Mon, Jul 24, 2023 at 1:33 AM Randy Dunlap wrote: >> >> Reconcile devices.txt with serial/ucc_uart.c regarding device number >> assignments. ucc_uart.c supports 4 ports and uses minor devnums >> 46-49, so update devices.txt with that info. >> Then update ucc_uart.c's reference to the location of the devices.txt >> list in the kernel source tree. >> >> Fixes: d7584ed2b994 ("[POWERPC] qe-uart: add support for Freescale QUICCEngine UART") >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") >> Signed-off-by: Randy Dunlap >> Cc: Timur Tabi >> Cc: Kumar Gala >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: Greg Kroah-Hartman >> Cc: Jiri Slaby >> Cc: linux-serial@vger.kernel.org >> Cc: Jonathan Corbet >> Cc: linux-doc@vger.kernel.org > > Acked-by: Timur Tabi > > One thing does concern me. The UCC UART driver piggy-backs on the CPM > driver's layout (see cpm_uart.h), but apparently CPM UART supports 6 > devices, not four: > > #define UART_NR fs_uart_nr > > where fs_uart_nr is defined in enum fs_uart_id. > > Unfortunately, it's been so long since I've touched this code, I'm not > sure whether this means anything. If CPM UART code ever worked with > 4 ports, it probably just used minor devnums that were not allocated to it. Also, it looks like the CPU UART part of Documentation/admin-guide/devices.txt needs to be updated: 46 = /dev/cucpm0 Callout device for ttyCPM0 ... 49 = /dev/cucpm5 Callout device for ttyCPM5 The driver must use some tricks to get 6 ports into 4 devnums. :) -- ~Randy