Kernel 2.6.10 running on mpc8272ads

Kernel 2.6.10 running on mpc8272ads

[alebas]

Hi to all,

Finally I got my mpc8272ads board running the 2.6.20-rc1 kernel.
The trick was:

First, I had to comment out the BCSR modification for second UART
in m82xx_board_init function (arch/ppc/platforms/pq2ads.c). As
suggested by Dan Malek, MMU is still off at this point.

Second, the uboot bootargs must be modified from those used for
kernel 2.4. Now, the selected console has to be ttyCPM. This
was unnecesary in kernel 2.4, as correct console was selected
by default.

Best regards

Re: Kernel 2.6.10 running on mpc8272ads

[Tom Rini]

On Thu, Dec 09, 2004 at 10:42:57AM +0100, alebas@televes.com wrote:

> Hi to all,
> 
> Finally I got my mpc8272ads board running the 2.6.20-rc1 kernel.
> The trick was:
> 
> First, I had to comment out the BCSR modification for second UART
> in m82xx_board_init function (arch/ppc/platforms/pq2ads.c). As
> suggested by Dan Malek, MMU is still off at this point.

Indeed.  While I had a PQ2FADS for a bit, I had to do that as well.
Kumar, what/why is that needed exactly?  Did I screw up in re-working
the 82xx init stuff and it needs to happen a bit later in boot?

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: Kernel 2.6.10 running on mpc8272ads

[Dan Malek]

On Jan 5, 2005, at 12:48 PM, Tom Rini wrote:

> Indeed.  While I had a PQ2FADS for a bit, I had to do that as well.
> Kumar, what/why is that needed exactly?  Did I screw up in re-working
> the 82xx init stuff and it needs to happen a bit later in boot?

I don't understand the what/why question, but that has never stopped
me from providing answers in the past :-)

So, In 2.6, and I think in some of the 2.4 cpm2 stuff, we no longer
automatically map any of the hardware IO resources for common
access like I used to do in the past.  If you want to access the
BCSR, you need to make sure it is ioremap()'ed in your driver before
you make the access.  Was that the question, or was it that
the BCSR should have been set someplace outside of the
driver for the serial port to work?


	-- Dan

Re: Kernel 2.6.10 running on mpc8272ads

[Tom Rini]

On Wed, Jan 05, 2005 at 02:03:11PM -0500, Dan Malek wrote:
> 
> On Jan 5, 2005, at 12:48 PM, Tom Rini wrote:
> 
> >Indeed.  While I had a PQ2FADS for a bit, I had to do that as well.
> >Kumar, what/why is that needed exactly?  Did I screw up in re-working
> >the 82xx init stuff and it needs to happen a bit later in boot?
> 
> I don't understand the what/why question, but that has never stopped
> me from providing answers in the past :-)

Ha!

> So, In 2.6, and I think in some of the 2.4 cpm2 stuff, we no longer
> automatically map any of the hardware IO resources for common
> access like I used to do in the past.  If you want to access the
> BCSR, you need to make sure it is ioremap()'ed in your driver before
> you make the access.  Was that the question, or was it that
> the BCSR should have been set someplace outside of the
> driver for the serial port to work?

Actually, I did break it.  When I re-worked the hooks around
platform_init/ppc_md.setup_arch, I added a call-out from platform_init()
but not from m82xx_setup_arch(), when I really needed one.  I'll follow
up with a patch momentarily.

-- 
Tom Rini
http://gate.crashing.org/~trini/

[PATCH 2.6.10] ppc32: Fix mpc8272ads

[Tom Rini]

When I reworked the m82xx init functions, I inadvertantly broke the
callout we had from ppc_md.setup_arch() that boards can use to poke &
prod things, once mappings are set.  The following adds in a callback
and updates the one m82xx board that needs it.

Signed-off-by: Tom Rini <trini@kernel.crashing.org>

--- 1.28/arch/ppc/syslib/m8260_setup.c	2004-11-24 23:42:43 -07:00
+++ edited/arch/ppc/syslib/m8260_setup.c	2005-01-12 07:18:14 -07:00
@@ -37,6 +37,12 @@
 extern void m8260_find_bridges(void);
 extern void idma_pci9_init(void);
 
+/* Place-holder for board-specific init */
+void __attribute__ ((weak)) __init
+m82xx_board_setup(void)
+{
+}
+
 static void __init
 m8260_setup_arch(void)
 {
@@ -56,6 +62,7 @@
 	if (initrd_start)
 		ROOT_DEV = Root_RAM0;
 #endif
+	m82xx_board_setup();
 }
 
 /* The decrementer counts at the system (internal) clock frequency
@@ -203,7 +210,7 @@
 	io_block_mapping(IO_VIRT_ADDR, IO_PHYS_ADDR, 0x10000000, _PAGE_IO);
 }
 
-/* Place-holder for board-specific init */
+/* Place-holder for board-specific ppc_md hooking */
 void __attribute__ ((weak)) __init
 m82xx_board_init(void)
 {
--- 1.6/arch/ppc/platforms/pq2ads.c	2004-08-13 16:33:54 -07:00
+++ edited/arch/ppc/platforms/pq2ads.c	2005-01-10 16:32:52 -07:00
@@ -19,8 +19,8 @@
 #include <asm/mpc8260.h>
 
 void __init
-m82xx_board_init(void)
+m82xx_board_setup(void)
 {
 	/* Enable the 2nd UART port */
-        *(volatile uint *)(BCSR_ADDR + 4) &= ~BCSR1_RS232_EN2;
+	*(volatile uint *)(BCSR_ADDR + 4) &= ~BCSR1_RS232_EN2;
 }

-- 
Tom Rini
http://gate.crashing.org/~trini/