linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jerome Glisse <j.glisse@free.fr>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: PATCH uninorth3 (G5) agp support
Date: Mon, 27 Dec 2004 09:50:05 +0100	[thread overview]
Message-ID: <1104137405.5615.17.camel@gaston> (raw)
In-Reply-To: <41CEC6B0.5020106@free.fr>


> +	if((uninorth_rev >= 0x30) && (uninorth_rev <= 0x33)) {
> +		/*
> +		 * We need to to set REQ_DEPTH to 7 for U3 versions 1.0, 2.1,
> +		 * 2.2 and 2.3, Darwin do so.
> +		 */
> +		command |= (7 << AGPSTAT_RQ_DEPTH_SHIFT);
> +	}
>  

Some revs of U3 (3.x) do have some high bits sets in the version
register, you should probably mask it with 0x3f ... Though on the other
hand, I don't know if revisions prior to 3.x were ever used on
production...

Ben.

  reply	other threads:[~2004-12-27  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-26 14:12 PATCH uninorth3 (G5) agp support Jerome Glisse
2004-12-27  8:50 ` Benjamin Herrenschmidt [this message]
2004-12-27  8:52 ` Benjamin Herrenschmidt
2004-12-27 12:51   ` Jerome Glisse
2004-12-27 13:32     ` Benjamin Herrenschmidt
2004-12-27 13:50       ` Jerome Glisse
2004-12-27 13:52         ` Benjamin Herrenschmidt
2005-01-03 18:56     ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1104137405.5615.17.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=j.glisse@free.fr \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=linuxppc64-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).