From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jerome Glisse <j.glisse@free.fr>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: PATCH uninorth3 (G5) agp support
Date: Mon, 27 Dec 2004 09:52:06 +0100 [thread overview]
Message-ID: <1104137527.5615.20.camel@gaston> (raw)
In-Reply-To: <41CEC6B0.5020106@free.fr>
> +/* The following seems to only be used only on U3 <j.glisse@free.fr> */
> +#define UNI_N_CFG_GART_SYNCMODE 0x00040000
> +#define UNI_N_CFG_GART_PERFRD 0x00080000
> +#define UNI_N_CFG_GART_B2BGNT 0x00200000
> +#define UNI_N_CFG_GART_FASTDDR 0x00400000
Please, call them U3_*
> /* My understanding of UniNorth AGP as of UniNorth rev 1.0x,
> * revision 1.5 (x4 AGP) may need further changes.
> diff -Naur linux/include/linux/pci_ids.h linux-new/include/linux/pci_ids.h
> --- linux/include/linux/pci_ids.h 2004-12-26 14:40:05.000000000 +0100
> +++ linux-new/include/linux/pci_ids.h 2004-12-26 14:50:19.000000000 +0100
> @@ -842,6 +842,7 @@
> #define PCI_DEVICE_ID_APPLE_UNI_N_GMAC2 0x0032
> #define PCI_DEVIEC_ID_APPLE_UNI_N_ATA 0x0033
> #define PCI_DEVICE_ID_APPLE_UNI_N_AGP2 0x0034
> +#define PCI_DEVICE_ID_APPLE_UNI_N_AGP3 0x0059
> #define PCI_DEVICE_ID_APPLE_IPID_ATA100 0x003b
> #define PCI_DEVICE_ID_APPLE_KEYLARGO_I 0x003e
> #define PCI_DEVICE_ID_APPLE_K2_ATA100 0x0043
Plase, call it PCI_DEVICE_ID_APPLE_U3_AGP
The name of the chip is not "UniNorth 3" but "U3" :) (Same goes with U2
btw).
Ben.
next prev parent reply other threads:[~2004-12-27 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-26 14:12 PATCH uninorth3 (G5) agp support Jerome Glisse
2004-12-27 8:50 ` Benjamin Herrenschmidt
2004-12-27 8:52 ` Benjamin Herrenschmidt [this message]
2004-12-27 12:51 ` Jerome Glisse
2004-12-27 13:32 ` Benjamin Herrenschmidt
2004-12-27 13:50 ` Jerome Glisse
2004-12-27 13:52 ` Benjamin Herrenschmidt
2005-01-03 18:56 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104137527.5615.20.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=j.glisse@free.fr \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).