linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: BUG: 2.6.11-rc2 and -rc1 hang during boot on PowerMacs
Date: Mon, 24 Jan 2005 12:25:35 +1100	[thread overview]
Message-ID: <1106529935.5587.9.camel@gaston> (raw)
In-Reply-To: <1106441036.5387.41.camel@gaston>

On Sun, 2005-01-23 at 11:43 +1100, Benjamin Herrenschmidt wrote:

> I know about this problem, I'm working on a proper fix. Thanks for your
> report.

Can you send me the PVR value for both of these CPUs
(cat /proc/cpuinfo) ? I can't find right now why they would lock up
unless the default idle loop is _not_ run properly, that is for some
reason, NAP or DOZE mode end up not beeing enabled. Can you send me
your .config as well ?

Finally, try that patch and tell me if it makes a difference. It makes
sure we re-enable interrupts in cpu_idle, and thus should only be a
workaround. I found _one_ actual code path where we fail to re-enable
them, and this is when neither DOZE nor NAP mode is enabled, which
should not happen on any G3 (they should all support DOZE mode), and
might happe non some G4s if the chipset doesn't support NAP or
powersave_nap is set to 0 in proc, but that shouldn't be the case of an
eMac neither...

--- linux-work.orig/arch/ppc/kernel/idle.c	2005-01-24 11:42:35.000000000 +1100
+++ linux-work/arch/ppc/kernel/idle.c	2005-01-24 12:19:41.114353760 +1100
@@ -39,17 +39,15 @@
 	powersave = ppc_md.power_save;
 
 	if (!need_resched()) {
+		local_irq_enable();
 		if (powersave != NULL)
 			powersave();
 		else {
 #ifdef CONFIG_SMP
 			set_thread_flag(TIF_POLLING_NRFLAG);
-			local_irq_enable();
 			while (!need_resched())
 				barrier();
 			clear_thread_flag(TIF_POLLING_NRFLAG);
-#else
-			local_irq_enable();
 #endif
 		}
 	}
 
Ben.

  reply	other threads:[~2005-01-24  1:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-22 17:23 BUG: 2.6.11-rc2 and -rc1 hang during boot on PowerMacs Mikael Pettersson
2005-01-23  0:43 ` Benjamin Herrenschmidt
2005-01-24  1:25   ` Benjamin Herrenschmidt [this message]
2005-01-24 17:42     ` Mikael Pettersson
2005-01-25  3:25       ` Benjamin Herrenschmidt
2005-01-25  8:56         ` Mikael Pettersson
2005-01-25 23:47           ` Benjamin Herrenschmidt
2005-01-26 10:02             ` Mikael Pettersson
2005-01-26 13:51               ` Benjamin Herrenschmidt
2005-01-26 21:33     ` Sylvain Munaut
2005-01-26 22:11       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1106529935.5587.9.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikpe@csd.uu.se \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).