From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 1ED3467A95 for ; Tue, 25 Jan 2005 13:32:02 +1100 (EST) From: Benjamin Herrenschmidt To: Kumar Gala In-Reply-To: References: Content-Type: text/plain Date: Tue, 25 Jan 2005 13:31:32 +1100 Message-Id: <1106620292.15850.5.camel@gaston> Mime-Version: 1.0 Cc: Andrew Morton , waite@skycomputers.com, Linux Kernel list , linuxppc-dev list Subject: Re: [PATCH] ppc32: fix powersave with interrupts disabled List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2005-01-24 at 15:51 -0600, Kumar Gala wrote: > It looks like the problem has to do with entering the powersave routine > with irqs disabled. Here is a patch that will only enter powersave if irqs > are enabled. > > Entering powersave on PPC while irqs are disabled causes a hang. Only > enter powersave if irqs are disabled. I have a different fix which is to re-enable them (basically to move the local_irq_disable we do in #ifdef CONFIG_SMP above the whole block, removing the #else case). I'm waiting for Ingo's ack about what exact race he's trying to fix though... Ben.