From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@freescale.com>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
rvinson@mvista.com,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linuxppc-embedded@ozlabs.org
Subject: [PATCH] ppc64: Missing call to ioremap in pci_iomap()
Date: Tue, 25 Jan 2005 13:35:33 +1100 [thread overview]
Message-ID: <1106620533.21888.1.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.61.0501241543530.23252@blarg.somerset.sps.mot.com>
On Mon, 2005-01-24 at 15:46 -0600, Kumar Gala wrote:
> The PPC version of pci_iomap seems to be missing a call to ioremap. This
> patch corrects that oversight and has been tested on a IBM PPC750FX Eval
> board.
Looks like the ppc64 version as well !
This patch adds the missing ioremap call to pci_iomap on ppc64.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/arch/ppc64/kernel/iomap.c
===================================================================
--- linux-work.orig/arch/ppc64/kernel/iomap.c 2005-01-24 11:42:36.000000000 +1100
+++ linux-work/arch/ppc64/kernel/iomap.c 2005-01-25 13:33:13.000000000 +1100
@@ -113,7 +113,7 @@
if (flags & IORESOURCE_IO)
return ioport_map(start, len);
if (flags & IORESOURCE_MEM)
- return (void __iomem *) start;
+ return ioremap(start, len);
/* What? */
return NULL;
}
prev parent reply other threads:[~2005-01-25 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 21:46 [PATCH] ppc32: Missing call to ioremap in pci_iomap() Kumar Gala
2005-01-25 2:35 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106620533.21888.1.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=galak@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=rvinson@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).