linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ppc32: Missing call to ioremap in pci_iomap()
@ 2005-01-24 21:46 Kumar Gala
  2005-01-25  2:35 ` [PATCH] ppc64: " Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2005-01-24 21:46 UTC (permalink / raw)
  To: akpm; +Cc: linuxppc-dev, rvinson, linux-kernel, linuxppc-embedded

The PPC version of pci_iomap seems to be missing a call to ioremap. This 
patch corrects that oversight and has been tested on a IBM PPC750FX Eval 
board.

Signed-off-by Randy Vinson <rvinson@mvista.com>
Signed-off-by Kumar Gala <kumar.gala@freescale.com>

---
diff -Nru a/arch/ppc/kernel/pci.c b/arch/ppc/kernel/pci.c
--- a/arch/ppc/kernel/pci.c	2005-01-24 15:43:19 -06:00
+++ b/arch/ppc/kernel/pci.c	2005-01-24 15:43:19 -06:00
@@ -1712,7 +1712,11 @@
 	if (flags & IORESOURCE_IO)
 		return ioport_map(start, len);
 	if (flags & IORESOURCE_MEM)
-		return (void __iomem *) start;
+		/* Not checking IORESOURCE_CACHEABLE because PPC does
+		 * not currently distinguish between ioremap and
+		 * ioremap_nocache.
+		 */
+		return ioremap(start, len);
 	/* What? */
 	return NULL;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-01-25  2:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-24 21:46 [PATCH] ppc32: Missing call to ioremap in pci_iomap() Kumar Gala
2005-01-25  2:35 ` [PATCH] ppc64: " Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).