From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Benjamin Herrenschmidt To: Chris Friesen In-Reply-To: <42077EE0.2060505@nortel.com> References: <41FECA18.50609@nortelnetworks.com> <1107243398.4208.47.camel@laptopd505.fenrus.org> <41FFA21C.8060203@nortelnetworks.com> <1107273017.4208.132.camel@laptopd505.fenrus.org> <20050204203050.GA5889@dmt.cnet> <4203D793.1040604@nortel.com> <1107595148.30302.5.camel@gaston> <42077EE0.2060505@nortel.com> Content-Type: text/plain Date: Tue, 08 Feb 2005 08:35:01 +1100 Message-Id: <1107812101.7734.42.camel@gaston> Mime-Version: 1.0 Cc: linuxppc64-dev , Arjan van de Ven , Linux Kernel list , linuxppc-dev list Subject: Re: question on symbol exports List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2005-02-07 at 08:44 -0600, Chris Friesen wrote: > Benjamin Herrenschmidt wrote: > >>It turns out that to call ptep_clear_flush_dirty() on ppc64 from a > >>module I needed to export the following symbols: > >> > >>__flush_tlb_pending > >>ppc64_tlb_batch > >>hpte_update > > > > > > Any reason why you need to call that from a module ? Is the module > > GPL'd ? > > I explained this at the beginning of the thread, but I'll do so again. > The module will be released under the GPL. > > The basic idea is that we want to be able to track pages dirtied by a > userspace process. The system has no swap, so we use the dirty bit for > this. On demand we look up the page tables for an address range > specified by the caller, store the addresses of any dirty pages, then > mark them clean so that the next write causes them to get marked dirty > again. It is this act of marking them clean that requires the > additional exports. > > I've included the current code below. If there is any way to accomplish > this without the additional exports, I'd love to hear about it. Interesting... more than no swap, you must also make sure you have no r/w mmap'ed file (which are technically equivalent to swap). I'm not too fan about exporting those symbols, but I'll talk to paulus, it should be possible at least to EXPORT_SYMBOL_GPL them... Ben.