From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] sungem update
Date: Wed, 09 Feb 2005 15:32:50 +1100 [thread overview]
Message-ID: <1107923570.7686.94.camel@gaston> (raw)
In-Reply-To: <20050208164042.6dd6fcb0.davem@davemloft.net>
Hi !
> Sorry for taking so long to review this :-/
No worries.
> This looks fine, except for one thing. The WOL_* registers don't exist
> in the Sun variants of the GEM chip, so it's not safe to try and program
> them on all chips blindly like these changes do. Perhaps some bit test
> like:
>
> if (pdev->vendor != PCI_VENDOR_ID_SUN)
> gp->flags |= GEM_HAS_WOL;
>
> Then protect all the WOL_* register programming with this new
> GEM_HAS_WOL flag.
Ok, I'll have a look.
Ben.
prev parent reply other threads:[~2005-02-09 4:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 6:10 [PATCH] sungem update Benjamin Herrenschmidt
2005-01-26 6:42 ` David S. Miller
2005-01-26 13:40 ` Benjamin Herrenschmidt
2005-02-09 0:40 ` David S. Miller
2005-02-09 4:32 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107923570.7686.94.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).