From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Fedin <sonic_amiga@rambler.ru>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Non-DMA mode for floppy on PowerPC, new version
Date: Wed, 09 Mar 2005 15:03:33 +1100 [thread overview]
Message-ID: <1110341013.32524.44.camel@gaston> (raw)
In-Reply-To: <20050224115307.79c1d32c.sonic_amiga@rambler.ru>
On Thu, 2005-02-24 at 11:53 -0500, Pavel Fedin wrote:
> Here is a cleaned up version of my 2.6.8 kernel patch.
>
> .../...
Where is "can_use_virtual_dma" defined ? I think that should be made
a bit more clean. Except for that, it looks ok I suppose (my knowledge
of this legacy cruft is quite poor :)
Also, do you need to re-implement your own allocation routine ? Just
use get_dma_pages in both...
A pure style issue also: your static initialization should use C99
initializers (.field = value)
"fd_routine" could be renamed to something nicer, like fd_dma_ops (more
linux-style).
I haven't looked at the logic of the vdma code itself, I suppose that if
it works, it's good enough :)
Ben.
next prev parent reply other threads:[~2005-03-09 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 16:53 [PATCH] Non-DMA mode for floppy on PowerPC, new version Pavel Fedin
2005-03-09 4:03 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-24 15:30 Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110341013.32524.44.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sonic_amiga@rambler.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).