Laptop sleep & current "git" tree

Laptop sleep & current "git" tree

[Benjamin Herrenschmidt]

Hi folks !

All my pending patches regarding power management are now upstream in
Linus "git" repository. That means I expect those to fix all known
issues (with the notable exception of the USB related problems, all of
these things aren't yet there but they aren't under my control, so still
unplug USB devices).

I would appreciate extensive testing, provided you figure out how to
retreive the "git" repository from kernel.org :) There must be some
howto somewhere, but I'm afraid I don't have a link at hand.

For those who can't dare experimenting with that new git toy, best may
be for you to wait for 2.6.12-rc4 which will contain all of these.

Cheers,
Ben.

Re: Laptop sleep & current "git" tree

[Colin Leroy]

On Tue, 03 May 2005 08:15:33 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

Hi Ben,

> All my pending patches regarding power management are now upstream in
> Linus "git" repository. That means I expect those to fix all known
> issues (with the notable exception of the USB related problems, all of
> these things aren't yet there but they aren't under my control, so
> still unplug USB devices).

All the USB patches from David Brownell that I tracked are in
git too, including the ehci repower stuff I sent him. I don't have
issues with these patches applied. Do you?

-- 
Colin

Re: Laptop sleep & current "git" tree

[Benjamin Herrenschmidt]

On Tue, 2005-05-03 at 08:37 +0200, Colin Leroy wrote:
> On Tue, 03 May 2005 08:15:33 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> Hi Ben,
> 
> > All my pending patches regarding power management are now upstream in
> > Linus "git" repository. That means I expect those to fix all known
> > issues (with the notable exception of the USB related problems, all of
> > these things aren't yet there but they aren't under my control, so
> > still unplug USB devices).
> 
> All the USB patches from David Brownell that I tracked are in
> git too, including the ehci repower stuff I sent him. I don't have
> issues with these patches applied. Do you?

I have no problem but I didn't see the hub power switching patch on my
git commit logs and it wasn't in linus tree yesterday at least :) I'll
dbl check later today. It's on greg's queue though for sure so it should
be in 2.6.12 hopefully.

Ben.

Re: Laptop sleep & current "git" tree

[Colin Leroy]

On Wed, 04 May 2005 09:50:56 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> I have no problem but I didn't see the hub power switching patch on my
> git commit logs and it wasn't in linus tree yesterday at least :) I'll
> dbl check later today. It's on greg's queue though for sure so it
> should be in 2.6.12 hopefully.

Yes, I was mistaken, what I wanted to say is that it's in gregkh and 
-mm :)
I hope it'll go in, it could be one of the first perfect kernel for
apple laptops !

-- 
Colin

Re: Laptop sleep & current "git" tree

[Colin Leroy]

On 04 May 2005 at 09h05, Benjamin Herrenschmidt wrote:

Hi, 

> I have no problem but I didn't see the hub power switching patch on my
> git commit logs and it wasn't in linus tree yesterday at least :)

Btw, it's in now.
http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=56c1e26d75008d39f1067f453719857a81109d9f

-- 
Colin

Re: Laptop sleep & current "git" tree

[John Steele Scott]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

Colin Leroy <colin@colino.net> writes:
> On 04 May 2005 at 09h05, Benjamin Herrenschmidt wrote:
>
> Hi, 
>
>> I have no problem but I didn't see the hub power switching patch on my
>> git commit logs and it wasn't in linus tree yesterday at least :)
>
> Btw, it's in now.

I finally tried this today, using 2.6.12-rc4, which has this patch. Without
USB devices attached, it's okay, but with my USB hub attached, I get a
(reproducable) panic in echi_hcd on the way to sleep.

I took a photo of the panic and enhanced it for readability, it's at
<http://www.toojays.net/portal/Members/toojays/ibook-g4-sleep-crash-2.6.12-rc4.jpg>.

cheers,

John

[-- Attachment #2: Type: application/pgp-signature, Size: 282 bytes --]

Re: Laptop sleep & current "git" tree

[Colin Leroy]

On 08 May 2005 at 14h05, John Steele Scott wrote:

Hi, 

> I finally tried this today, using 2.6.12-rc4, which has this patch.
> Without USB devices attached, it's okay, but with my USB hub
> attached, I get a (reproducable) panic in echi_hcd on the way to
> sleep.
> 
> I took a photo of the panic and enhanced it for readability, it's at
> <http://www.toojays.net/portal/Members/toojays/ibook-g4-sleep-crash-2.6.12-rc4.jpg>.

linux-usb-devel may be interested. (I don't have an usb hub so can't
test it)

-- 
Colin

Re: Laptop sleep & current "git" tree

[John Steele Scott]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Colin Leroy <colin@colino.net> writes:
> On 08 May 2005 at 14h05, John Steele Scott wrote:
>> I finally tried this today, using 2.6.12-rc4, which has this patch.
>> Without USB devices attached, it's okay, but with my USB hub
>> attached, I get a (reproducable) panic in echi_hcd on the way to
>> sleep.
>> 
>> I took a photo of the panic and enhanced it for readability, it's at
>> <http://www.toojays.net/portal/Members/toojays/ibook-g4-sleep-crash-2.6.12-rc4.jpg>.
>
> linux-usb-devel may be interested. (I don't have an usb hub so can't
> test it)

I forwarded the bug report to linux-usb-devel as per Colin's suggestion, and
David Brownell has fixed it. His post, which includes the patch, can be found
at <http://marc.theaimsgroup.com/?l=linux-usb-devel&m=111558764113428&w=2>

cheers,

John

[-- Attachment #2: Type: application/pgp-signature, Size: 282 bytes --]

Re: Laptop sleep & current "git" tree

[Colin Leroy]

On Mon, 09 May 2005 08:05:18 +0930
John Steele Scott <toojays@toojays.net> wrote:

> I forwarded the bug report to linux-usb-devel as per Colin's
> suggestion, and David Brownell has fixed it. His post, which includes
> the patch, can be found at
> <http://marc.theaimsgroup.com/?l=linux-usb-devel&m=111558764113428&w=2>

Great! Do you know if he plans pushing it to 2.6.12 quickly? 

-- 
Colin

Re: Laptop sleep & current "git" tree

[John Steele Scott]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Colin Leroy <colin@colino.net> writes:
> On Mon, 09 May 2005 08:05:18 +0930
> John Steele Scott <toojays@toojays.net> wrote:
>
>> I forwarded the bug report to linux-usb-devel as per Colin's
>> suggestion, and David Brownell has fixed it. His post, which includes
>> the patch, can be found at
>> <http://marc.theaimsgroup.com/?l=linux-usb-devel&m=111558764113428&w=2>
>
> Great! Do you know if he plans pushing it to 2.6.12 quickly? 

I don't know. After fixing that hub issue, I still get an oops if my USB
trackball is connected during sleep.

cheers,

John

[-- Attachment #2: Type: application/pgp-signature, Size: 282 bytes --]

Re: Laptop sleep & current "git" tree

[David Woodhouse]

On Tue, 2005-05-03 at 08:15 +1000, Benjamin Herrenschmidt wrote:
> For those who can't dare experimenting with that new git toy, best may
> be for you to wait for 2.6.12-rc4 which will contain all of these.

The latest Fedora Core kernel from
http://people.redhat.com/davej/kernels/Fedora/FC4/RPMS.kernel/ ought to
contain them all too, along with a fix for the EHCI port power switching
problem.

-- 
dwmw2

Re: Laptop sleep & current "git" tree

[Ian Wienand]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On Tue, May 03, 2005 at 08:15:33AM +1000, Benjamin Herrenschmidt wrote:
> I would appreciate extensive testing, provided you figure out how to
> retreive the "git" repository from kernel.org :) There must be some
> howto somewhere, but I'm afraid I don't have a link at hand.

It's so far working well for me on an 800Mhz iBook (750fx) after quite
a few sleep and resume cycles.

Is there a fix in the works for the Radeon timing thing that makes the
screen go a little weird on wakeup?

FWIW, the two step way to get the git tree I followed was

wget http://www.kernel.org/pub/software/scm/cogito/cogito-0.8.tar.bz2
(install, modify path in Makefile if you want)

cd /usr/src
mkdir linux-2.6-git
cd linux-2.6-git
cg-init rsync://rsync.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

-i
ianw@gelato.unsw.edu.au
http://www.gelato.unsw.edu.au

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Laptop sleep & current "git" tree

[Benjamin Herrenschmidt]

On Wed, 2005-05-04 at 08:22 +1000, Ian Wienand wrote:
> On Tue, May 03, 2005 at 08:15:33AM +1000, Benjamin Herrenschmidt wrote:
> > I would appreciate extensive testing, provided you figure out how to
> > retreive the "git" repository from kernel.org :) There must be some
> > howto somewhere, but I'm afraid I don't have a link at hand.
> 
> It's so far working well for me on an 800Mhz iBook (750fx) after quite
> a few sleep and resume cycles.
> 
> Is there a fix in the works for the Radeon timing thing that makes the
> screen go a little weird on wakeup?

I don't know this problem, what happens precisely and what model of
radeon chip do you have ?

> FWIW, the two step way to get the git tree I followed was
> 
> wget http://www.kernel.org/pub/software/scm/cogito/cogito-0.8.tar.bz2
> (install, modify path in Makefile if you want)
> 
> cd /usr/src
> mkdir linux-2.6-git
> cd linux-2.6-git
> cg-init rsync://rsync.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> 
> -i
> ianw@gelato.unsw.edu.au
> http://www.gelato.unsw.edu.au
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>

Re: Laptop sleep & current "git" tree

[Ian Wienand]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

On Wed, May 04, 2005 at 09:41:30AM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2005-05-04 at 08:22 +1000, Ian Wienand wrote:
> > Is there a fix in the works for the Radeon timing thing that makes the
> > screen go a little weird on wakeup?
> 
> I don't know this problem, what happens precisely and what model of
> radeon chip do you have ?

We discussed it briefly previously

http://lists.debian.org/debian-powerpc/2005/04/msg00138.html

 "Ok. I suspect the wakeup effect might be caused by the delays in
 radeonfb that I added to work around some chip errata... You can try
 hacking them out from the errata function in radeonfb.h"

-i

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Laptop sleep & current "git" tree

[Benjamin Herrenschmidt]

On Wed, 2005-05-04 at 09:48 +1000, Ian Wienand wrote:
> On Wed, May 04, 2005 at 09:41:30AM +1000, Benjamin Herrenschmidt wrote:
> > On Wed, 2005-05-04 at 08:22 +1000, Ian Wienand wrote:
> > > Is there a fix in the works for the Radeon timing thing that makes the
> > > screen go a little weird on wakeup?
> > 
> > I don't know this problem, what happens precisely and what model of
> > radeon chip do you have ?
> 
> We discussed it briefly previously
> 
> http://lists.debian.org/debian-powerpc/2005/04/msg00138.html
> 
>  "Ok. I suspect the wakeup effect might be caused by the delays in
>  radeonfb that I added to work around some chip errata... You can try
>  hacking them out from the errata function in radeonfb.h"

Ah yes, those... oh well, that is not very urgent, and it should be a
bit better with my cmap batching patch. You can always hack locally and
remove the delay of 5ms in the PLL workaround in radeonfb.h since it
seems nobody ever really hits the bug taht this workaround is supposed
to fix...

Ben.

Re: Laptop sleep & current "git" tree

[Eddy Petrisor]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=x-user-defined; format=flowed, Size: 495 bytes --]

Benjamin Herrenschmidt wrote:
> 
> I don't know this problem, what happens precisely and what model of
> radeon chip do you have ?
> 
I am just interfering as you talked about radeon models; is there any 
good news regarding the >9600 chipsets?
I know there was a project (R300 iirc) that wanted to make a driver, but 
progress was slow or non-existant last time I heard about it.


-- 
Regards,
EddyP
===========================
I had a favourite quote, but I forgot it. And it was insightful.

Re: Laptop sleep & current "git" tree

[Benjamin Herrenschmidt]

On Sat, 2005-05-07 at 00:59 +0300, Eddy Petrisor wrote:
> Benjamin Herrenschmidt wrote:
> > 
> > I don't know this problem, what happens precisely and what model of
> > radeon chip do you have ?
> > 
> I am just interfering as you talked about radeon models; is there any 
> good news regarding the >9600 chipsets?
> I know there was a project (R300 iirc) that wanted to make a driver, but 
> progress was slow or non-existant last time I heard about it.

There is a fully working 2D driver and there is an in-progress 3D driver
based on some sort of reverse engineering. It works weel enough for some
things like tuxracer, pinball or bzflag :) You probably need to get all
sort of up to date CVS things to get it to work though (X.org, DRI and
Mesa)

Ben.

Re: Laptop sleep & current "git" tree

[Jerome Glisse]

> I am just interfering as you talked about radeon models; is there any
> good news regarding the >9600 chipsets?
> I know there was a project (R300 iirc) that wanted to make a driver, but
> progress was slow or non-existant last time I heard about it.

If you only check the web site you will miss most of the things. We don't
take much time updating it. We haven't got much time for that. A better
place to look is the commit mailing list, where you can see things going
on...

I think we will have some "final" driver by the end of the year, maybe
before as some developer are at school and may use their hollydays to
give a boost at development.

Jerome Glisse