[PATCH] add machine state register support

[PATCH] add machine state register support

[Geoff Levand]

This patch adds routines to get and set the machine state register.  These 
are needed by power management code on some platforms.

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> for CELF

--

Index:linux-2.6.11/arch/ppc/kernel/misc.S
===================================================================
--- linux-2.6.11.orig/arch/ppc/kernel/misc.S	2005-04-15 14:59:12.408518820 -0700
+++ linux-2.6.11/arch/ppc/kernel/misc.S	2005-04-15 14:59:34.005586781 -0700

@@ -1160,6 +1159,14 @@
 	addi	r1,r1,16
 	blr
 
+_GLOBAL(_get_msr)
+	mfmsr   r3
+	blr
+
+_GLOBAL(_set_msr)
+	mtmsr   r3
+	blr
+
 /*
  * This routine is just here to keep GCC happy - sigh...
  */

Re: [PATCH] add machine state register support

[Benjamin Herrenschmidt]

On Mon, 2005-05-23 at 16:40 -0700, Geoff Levand wrote:
> This patch adds routines to get and set the machine state register.  These 
> are needed by power management code on some platforms.
> 
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> for CELF

Hi Geoff !

Can you tell me more about this power management code ? I tend to think
that code that wants to do more than just using the existing accessors
should be written in assembly... 

Also, there is already

void _nmask_and_or_msr(unsigned long nmask, unsigned long or_val);

That you can use for manipulating MSR bits.

Finally, I tend to prefer such small register accessors to be written as
inline assembly in some headers. But then, I don't think you actually
need to add anything here.

Regards,
Ben.

Re: [PATCH] add machine state register support

[Geert Uytterhoeven]

On Mon, 23 May 2005, Geoff Levand wrote:
> This patch adds routines to get and set the machine state register.  These 
> are needed by power management code on some platforms.
> 
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> for CELF
> 
> --
> 
> Index:linux-2.6.11/arch/ppc/kernel/misc.S
> ===================================================================
> --- linux-2.6.11.orig/arch/ppc/kernel/misc.S	2005-04-15 14:59:12.408518820 -0700
> +++ linux-2.6.11/arch/ppc/kernel/misc.S	2005-04-15 14:59:34.005586781 -0700
> 
> @@ -1160,6 +1159,14 @@
>  	addi	r1,r1,16
>  	blr
>  
> +_GLOBAL(_get_msr)
> +	mfmsr   r3
> +	blr
> +
> +_GLOBAL(_set_msr)
> +	mtmsr   r3
> +	blr
> +

Please check m[ft]msr() in <asm/reg.h>.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] add machine state register support

[Geoff Levand]

Benjamin Herrenschmidt wrote:
> On Mon, 2005-05-23 at 16:40 -0700, Geoff Levand wrote:
> 
>>This patch adds routines to get and set the machine state register.  These 
>>are needed by power management code on some platforms.
>>
>>Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> for CELF
> 
> 
> Hi Geoff !
> 
> Can you tell me more about this power management code ? I tend to think
> that code that wants to do more than just using the existing accessors
> should be written in assembly... 
> 
> Also, there is already
> 
> void _nmask_and_or_msr(unsigned long nmask, unsigned long or_val);
> 
> That you can use for manipulating MSR bits.
> 
> Finally, I tend to prefer such small register accessors to be written as
> inline assembly in some headers. But then, I don't think you actually
> need to add anything here.
> 

Sorry for the trouble, Geert is right, there are already mfmsr() and 
mtmsr() in <ppc-asm/reg.h>.  I found get_msr in ppc64 and assumed they 
were missing for ppc.  I should have looked more carefully.

-Geoff