From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id B6ED767B5D for ; Wed, 29 Jun 2005 09:53:22 +1000 (EST) From: Benjamin Herrenschmidt To: Dan Malek In-Reply-To: <3e7207cd8e98080f2f469a668e37a20f@embeddededge.com> References: <20050625145318.GA32117@logos.cnet> <20050626143004.GA5198@logos.cnet> <20050627133930.GA9109@logos.cnet> <1119940208.5133.204.camel@gaston> <3e7207cd8e98080f2f469a668e37a20f@embeddededge.com> Content-Type: text/plain Date: Wed, 29 Jun 2005 09:47:54 +1000 Message-Id: <1120002475.5133.208.camel@gaston> Mime-Version: 1.0 Cc: linux-ppc-embedded Subject: Re: [PATCH] 8xx: map_page() skip pinned region and tlbie debugging aid List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2005-06-28 at 09:53 -0400, Dan Malek wrote: > On Jun 28, 2005, at 2:30 AM, Benjamin Herrenschmidt wrote: > > > You should consider 8Mb pages the way we do BATs yes, > > It's always been considered, just never fully implemented :-) > > > Note that I'll soon send the patch I told you about that makes the > > virtual address picked by io_block_mapping() dynamic, so we no longer > > have to do crappy assumptions all over the place :) > > Whatever, I'll never use it that way and no one else should either. That is stupid > All of the io_block_mapping() calls should be used to set these 8M I think you just never bothered actually reading all I wrote about that... None of what you describe requires hard coding the virtual address. This is just plain bad. > mapped IO spaces, everyone should use ioremap() to map them, > and ioremap() has to be modified to find them for the 8xx. We agree here.