linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Add modalias to macio sysfs attributes
Date: Tue, 11 Oct 2005 08:17:40 +1000	[thread overview]
Message-ID: <1128982661.17365.170.camel@gaston> (raw)
In-Reply-To: <20051010200739.GA14317@suse.de>

On Mon, 2005-10-10 at 22:07 +0200, Olaf Hering wrote:
> Provide a "compatible" entry in /sys/bus/macio/devices/*/
> This can be used to load drivers via the modules.alias file.
> 
> Author: <schab@suse.de>
> Signed-off-by: Olaf Hering <olh@suse.de>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> --- linux-2.6.13-rc7/drivers/macintosh/macio_sysfs.c.~1~	2005-08-26 16:32:13.000000000 +0200
> +++ linux-2.6.13-rc7/drivers/macintosh/macio_sysfs.c	2005-08-27 11:58:47.000000000 +0200
> @@ -39,6 +39,31 @@ compatible_show (struct device *dev, str
>  	return length;
>  }
>  
> +static ssize_t modalias_show (struct device *dev, struct device_attribute *attr,
> +			      char *buf)
> +{
> +	struct of_device *of;
> +	char *compat;
> +	int cplen;
> +	int length;
> +
> +	of = &to_macio_device (dev)->ofdev;
> +	compat = (char *) get_property (of->node, "compatible", &cplen);
> +	if (!compat) compat = "", cplen = 1;
> +	length = sprintf (buf, "of:N%sT%s", of->node->name, of->node->type);
> +	buf += length;
> +	while (cplen > 0) {
> +		int l;
> +		length += sprintf (buf, "C%s", compat);
> +		buf += length;
> +		l = strlen (compat) + 1;
> +		compat += l;
> +		cplen -= l;
> +	}
> +
> +	return length;
> +}
> +
>  macio_config_of_attr (name, "%s\n");
>  macio_config_of_attr (type, "%s\n");
>  
> @@ -46,5 +71,6 @@ struct device_attribute macio_dev_attrs[
>  	__ATTR_RO(name),
>  	__ATTR_RO(type),
>  	__ATTR_RO(compatible),
> +	__ATTR_RO(modalias),
>  	__ATTR_NULL
>  };

      parent reply	other threads:[~2005-10-10 22:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-10 20:07 [PATCH] Add modalias to macio sysfs attributes Olaf Hering
2005-10-10 20:11 ` [PATCH] Add modalias for pmac network drivers Olaf Hering
2005-10-10 22:16   ` Benjamin Herrenschmidt
2005-10-10 22:17 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1128982661.17365.170.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).