* [PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM
@ 2005-10-25 7:31 Nicolas DET
2005-10-25 7:33 ` Nicolas DET
2005-10-25 18:30 ` Dale Farnsworth
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas DET @ 2005-10-25 7:31 UTC (permalink / raw)
To: Sven Luther, Andrew Morton, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
Added information message when using the SRAM in mv643xx_eth_probe()
Signed-off-by: Nicolas DET <det.nicolas@free.fr>
Signed-off-by: Sven Luther <sl@bplan-gmbh.de>
[-- Attachment #2: mv643xx_eth_showsram_2.6.14-rc5.diff --]
[-- Type: text/x-patch, Size: 398 bytes --]
diff -Naur a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
--- a/drivers/net/mv643xx_eth.c 2005-10-25 09:24:57.952386000 +0200
+++ b/drivers/net/mv643xx_eth.c 2005-10-25 09:25:02.220386000 +0200
@@ -1533,6 +1533,9 @@
printk(KERN_NOTICE "%s: RX NAPI Enabled \n", dev->name);
#endif
+ if (mp->tx_sram_size > 0)
+ printk(KERN_NOTICE "%s: Using SRAM\n", dev->name);
+
return 0;
out:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM
2005-10-25 7:31 [PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM Nicolas DET
@ 2005-10-25 7:33 ` Nicolas DET
2005-10-25 18:30 ` Dale Farnsworth
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas DET @ 2005-10-25 7:33 UTC (permalink / raw)
To: linuxppc-dev
Le mardi 25 octobre 2005 à 09:31 +0200, Nicolas DET a écrit :
> Added information message when using the SRAM in mv643xx_eth_probe()
>
This is a tiny path. Nevertheless, I think it is useful to get this
information.
-
Regards
Nicolas DET
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM
2005-10-25 7:31 [PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM Nicolas DET
2005-10-25 7:33 ` Nicolas DET
@ 2005-10-25 18:30 ` Dale Farnsworth
1 sibling, 0 replies; 3+ messages in thread
From: Dale Farnsworth @ 2005-10-25 18:30 UTC (permalink / raw)
To: Nicolas DET, linuxppc-dev
On Tue, Oct 25, 2005 at 07:31:35AM +0000, Nicolas DET wrote:
> Added information message when using the SRAM in mv643xx_eth_probe()
>
> Signed-off-by: Nicolas DET <det.nicolas@free.fr>
> Signed-off-by: Sven Luther <sl@bplan-gmbh.de>
>
> diff -Naur a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> --- a/drivers/net/mv643xx_eth.c 2005-10-25 09:24:57.952386000 +0200
> +++ b/drivers/net/mv643xx_eth.c 2005-10-25 09:25:02.220386000 +0200
> @@ -1533,6 +1533,9 @@
> printk(KERN_NOTICE "%s: RX NAPI Enabled \n", dev->name);
> #endif
>
> + if (mp->tx_sram_size > 0)
> + printk(KERN_NOTICE "%s: Using SRAM\n", dev->name);
> +
> return 0;
>
> out:
Do you really think this is necessary? I think this driver is already
too verbose and we should be remove messages, not add them. :)
-Dale
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-10-25 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-25 7:31 [PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM Nicolas DET
2005-10-25 7:33 ` Nicolas DET
2005-10-25 18:30 ` Dale Farnsworth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).