Re: [PATCH] ppc64: Thermal control for SMU based machines

Re: [PATCH] ppc64: Thermal control for SMU based machines

[Geert Uytterhoeven]

On Mon, 7 Nov 2005, Linux Kernel Mailing List wrote:
> tree d3f63b3ea80790c2f29ea435781c1331f17d269e
> parent 7d49697ef92bd2cf84ab53bd4cea82fefb197fb9
> author Benjamin Herrenschmidt <benh@kernel.crashing.org> Mon, 07 Nov 2005 16:08:17 +1100
> committer Paul Mackerras <paulus@samba.org> Tue, 08 Nov 2005 11:17:56 +1100
> 
> [PATCH] ppc64: Thermal control for SMU based machines
> 
> This adds a new thermal control framework for PowerMac, along with the
> implementation for PowerMac8,1, PowerMac8,2 (iMac G5 rev 1 and 2), and
> PowerMac9,1 (latest single CPU desktop). In the future, I expect to move
> the older G5 thermal control to the new framework as well.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Paul Mackerras <paulus@samba.org>

> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -169,6 +169,25 @@ config THERM_PM72
>  	  This driver provides thermostat and fan control for the desktop
>  	  G5 machines. 
>  
> +config WINDFARM
> +	tristate "New PowerMac thermal control infrastructure"

Shouldn't this depend on some PowerMac-related variables, to prevent it from
showing up on m68k?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] ppc64: Thermal control for SMU based machines

[Benjamin Herrenschmidt]

> > --- a/drivers/macintosh/Kconfig
> > +++ b/drivers/macintosh/Kconfig
> > @@ -169,6 +169,25 @@ config THERM_PM72
> >  	  This driver provides thermostat and fan control for the desktop
> >  	  G5 machines. 
> >  
> > +config WINDFARM
> > +	tristate "New PowerMac thermal control infrastructure"
> 
> Shouldn't this depend on some PowerMac-related variables, to prevent it from
> showing up on m68k?

Well, the windfarm core is not really platform specific at all ...
Christoph even proposed to move it to some more "common" place, though
as I said, I want to work on it a bit more before that happens.

Ben.