From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] Fix USB suspend/resume crasher
Date: Fri, 25 Nov 2005 08:01:27 +1100 [thread overview]
Message-ID: <1132866088.26560.455.camel@gaston> (raw)
In-Reply-To: <200511242150.23205.rjw@sisk.pl>
>
> Well, it's there (actually the problem occurs in vanilla 2.6.15-rc2-mm1 that
> contains the patch). Do you mean it should go before the
>
> if (readl(&ehci->regs->configured_flag) != FLAG_CF)
> goto restart;
>
> thing?
Yes.
> > It may be worth following it with a memory barrier actually... just in case
> > (due to the absence of locks in that area).
>
> wmb()?
Yup.
I wrote that patch against a tree that had different things in that
function, Greg merged it by hand but he got that little bit wrong
unfortunately. I'll send a new patch later today.
Ben.
next prev parent reply other threads:[~2005-11-24 21:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 3:08 [PATCH] Fix USB suspend/resume crasher Benjamin Herrenschmidt
2005-11-23 3:09 ` Benjamin Herrenschmidt
2005-11-23 3:14 ` Nigel Cunningham
2005-11-23 5:13 ` Benjamin Herrenschmidt
2005-11-23 17:10 ` Greg KH
2005-11-23 18:58 ` David Brownell
2005-11-24 0:22 ` Rafael J. Wysocki
2005-11-24 1:23 ` Benjamin Herrenschmidt
2005-11-24 20:50 ` Rafael J. Wysocki
2005-11-24 21:01 ` Benjamin Herrenschmidt [this message]
2005-11-24 21:14 ` Rafael J. Wysocki
2005-11-24 21:22 ` Benjamin Herrenschmidt
2005-11-24 16:52 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1132866088.26560.455.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).